Closed
Bug 617074
Opened 14 years ago
Closed 14 years ago
Fix for building with Android 2.3 SDK (android-9 platform)
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: mobile, Whiteboard: [fennec-checkin-postb3])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mwu
:
review+
khuey
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
The latest Android SDK changed the location of the "platform tools" directory. This patch lets you build Fennec with the new SDK, if you add this option to your mozconfig:
--with-android-platform-tools="/path/to/android-sdk/platform-tools
Attachment #495568 -
Flags: review?(khuey)
|
||
Comment 1•14 years ago
|
||
2 things:
1. I would prefer just dropping support for the old sdk entirely. However, we have to sync up with releng to update the sdk so supporting the old sdk is fine..
2. We should be able to check for a platform-tools directory and use automatically if it's there.
(In reply to comment #1)
> 2 things:
> 1. I would prefer just dropping support for the old sdk entirely. However, we
> have to sync up with releng to update the sdk so supporting the old sdk is
> fine..
> 2. We should be able to check for a platform-tools directory and use
> automatically if it's there.
We generally try to avoid adding configure options unless we absolutely have to. I don't have any real opinion on multiple versions of the SDK. This looks good except for that configure option.
|
Assignee | |
Comment 3•14 years ago
|
||
Auto-detect the platform tools directory, rather than adding a configure option.
Also, remove the unused ANDROID_TOOLS configure variable.
Attachment #495568 -
Attachment is obsolete: true
Attachment #495854 -
Flags: review?(khuey)
Attachment #495568 -
Flags: review?(khuey)
Attachment #495854 -
Flags: review?(khuey)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 495854 [details] [diff] [review]
patch v2
Not sure why khuey canceled the review request; he's still welcome to chime in here if he has any opinion on the patch. Switching review to mwu.
Attachment #495854 -
Flags: review?(mwu)
Comment on attachment 495854 [details] [diff] [review]
patch v2
Bah, definitely meant to r+
Attachment #495854 -
Flags: review+
|
|
||
Updated•14 years ago
|
Attachment #495854 -
Flags: review?(mwu)
Attachment #495854 -
Flags: review+
Attachment #495854 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [fennec-checkin-postb3]
|
||
Updated•14 years ago
|
Attachment #495854 -
Flags: approval2.0? → approval2.0+
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•