Open Bug 617713 Opened 14 years ago Updated 2 years ago

provide symbol renaming for tremor/friends

Categories

(Core :: Audio/Video: Playback, defect, P3)

x86
Linux
defect

Tracking

()

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

coverity is "building" mozilla in a way that it sometimes finds libvorbisidec and sometimes finds tremor for headers. the result is that it complains about: nsOggCodecState.cpp: 310 nsVorbisState::~nsVorbisState() { 311 MOZ_COUNT_DTOR(nsVorbisState); Event overrun-buffer-val: Overrun of struct type vorbis_block of size 88 bytes by passing it as an argument to a function which indexes it at byte position 91 [details] 312 vorbis_block_clear(&mBlock); xulrunner/tremor/ivorbiscodec.h: 107 } vorbis_block; libvorbisidec/block.c: 138 int vorbis_block_clear(vorbis_block *vb){ 139 _vorbis_block_ripcord(vb); 140 if(vb->localstore)_ogg_free(vb->localstore); 141 Event access_dbuff_const: Call to function "memset" indexes buffer "vb" with index "92U" at byte position 91 142 memset(vb,0,sizeof(*vb)); libvorbisidec/ivorbiscodec.h: 107 } vorbis_block; This would be avoided if gecko had #define MOZ_RENAME(vorbis_thing) #define vorbis_thing moz_##vorbis_thing MOZ_RENAME(vorbis_block) MOZ_RENAME(vorbis_block_clear) or however it's done -- see cairo for code which does this right...
Component: Audio/Video → Audio/Video: Playback
Rank: 25
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.