Closed
Bug 617876
Opened 14 years ago
Closed 14 years ago
Fix up theme code from bug 601183
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Most notably, hard-coded rgb values and descendent selectors should usually be avoided. There's code duplication too.
Attachment #496443 -
Flags: review?(gavin.sharp)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 496443 [details] [diff] [review]
patch
Thanks, I should have paid more attention to this.
>diff --git a/toolkit/themes/gnomestripe/global/webConsole.css b/toolkit/themes/gnomestripe/global/webConsole.css
>+.jsterm-input-node,
>+.jsterm-complete-node {
>+ padding: 0 0 0 16px;
Should this use -moz-padding-end? I guess these are forced LTR?
>+.jsterm-input-node {
>+ width: 98%;
Is this needed? The other themes don't seem to have it, not sure what it's supposed to do...
Attachment #496443 -
Flags: review?(gavin.sharp)
Attachment #496443 -
Flags: review+
Attachment #496443 -
Flags: approval2.0+
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> Should this use -moz-padding-end? I guess these are forced LTR?
Yes, this always LTR.
> Is this needed? The other themes don't seem to have it, not sure what it's
> supposed to do...
I have no idea why it's there either...
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•