Closed
Bug 617916
Opened 14 years ago
Closed 11 years ago
XPCWrappedNativeScope::SystemIsBeingShutDown does not check ac.enter for failure
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
INVALID
People
(Reporter: timeless, Unassigned)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
according to coverity there are 112 calls to JSAutoEnterCompartment::enter, and this is the only one which doesn't check the result:
662 XPCWrappedNativeScope::SystemIsBeingShutDown(JSContext* cx)
663 {
688 for(cur = gDyingScopes; cur; cur = cur->mNext)
689 {
694 JSAutoEnterCompartment ac;
695
696 // XXX: What if we have no global in the scope???
697 if (cur->mGlobalJSObject)
698 ac.enter(cx, cur->mGlobalJSObject);
|
||
Comment 1•11 years ago
|
||
It looks like this method doesn't have JSAutoEnterCompartment any more, if that's even still a thing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
|
||
Comment 2•11 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #1)
> It looks like this method doesn't have JSAutoEnterCompartment any more, if
> that's even still a thing.
Yeah, it became JSAutoCompartment when it became infallible.
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•