Closed Bug 61801 Opened 24 years ago Closed 24 years ago

javascript strict warnings in FilterListDialog.js

Categories

(MailNews Core :: Filters, defect, P3)

Product:
MailNews Core
Component:
Filters
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: maolson)

References

Details

Attachments

(3 files)

patch - fix strict warnings
(deleted), patch
Details | Diff | Splinter Review
patch - a few more warnings, and make delete work again (along with patch to follow)
(deleted), patch
Details | Diff | Splinter Review
patch - move properties around so that delete filter works
(deleted), patch
Details | Diff | Splinter Review
JavaScript strict warning: chrome://messenger/content/FilterListDialog.js line 48: reference to undefined property window.arguments
Also... JavaScript strict warning: chrome://messenger/content/FilterListDialog.js line 166: reference to undefined property args.refresh
When you fix this, can someone verify, thanks!
Attached patch patch - fix strict warnings (deleted) — — Splinter Review
The first warning was cleaned up already. The attached patch gets at the others.
Keywords: patch, review
r=blake, cc'ing timeless for r=
r=jag
Hold up a sec, new patch imminent as I found some (existing) bugs while testing. (filter delete doesn't work) New patch momentarily.
r=jag Great job!
cc'ing sspitzer for sr
I'd like the module owner (gayatrib) to review and test this first, before I super review it.
since jag gave the review, and the fix looks like a slam dunk, sr=sspitzer gayatri can follow up later. mark, feel free to take this bug and check in your fix.
=>mao
Assignee: gayatrib → maolson
fix checked in
Status: NEW → RESOLVED
Closed: 24 years ago
Keywords: review
Resolution: --- → FIXED
Delete still doesn't work. (bug 68505)
QA Contact: esther → stephend
Verified FIXED. Saw no JS errors when Editing and Deleting a filter.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: