618052 - Intermittent test_utils_queryAsync.js | test failed (with xpcshell return code: 0) | false == true

Assignee

Description

•

14 years ago

Make sure updates work TEST-PASS | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | [run_test : 54] 0 == 0 Get the updated TEST-PASS | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | [run_test : 58] 1 == 1 TEST-PASS | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | [run_test : 59] more == more TEST-PASS | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | [run_test : 60] updated == updated Grabbing fewer fields than queried is fine TEST-PASS | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | [run_test : 64] 3 == 3 Generate an execution error TEST-UNEXPECTED-FAIL | /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js | false == true - See following stack: JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_throw :: line 424 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_check_eq :: line 476 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: do_check_true :: line 488 JS frame :: /Users/rnewman/moz/hg/services/fx-sync/services/sync/tests/unit/test_utils_queryAsync.js :: run_test :: line 73 JS frame :: /Users/rnewman/moz/hg/mozilla-central/testing/xpcshell/head.js :: _execute_test :: line 307 JS frame :: -e :: <TOP_LEVEL> :: line 1 TEST-INFO | (xpcshell/head.js) | exiting test

Phil Ringnalda (:philor)

Comment 1

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1293676232.1293677281.13896.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test xpcshell on 2010/12/29 18:30:32 s: talos-r3-snow-005

Blocks: 438871

Whiteboard: [orange]

Phil Ringnalda (:philor)

Comment 2

•

14 years ago

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1295449436.1295450037.9714.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central opt test xpcshell on 2011/01/19 07:03:56 s: talos-r3-snow-035

Summary: test_utils_queryAsync sometimes fails → Intermittent test_utils_queryAsync.js | test failed (with xpcshell return code: 0) | false == true

Comment hidden (Legacy TBPL/Treeherder Robot)

khuey http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1301581061.1301582096.1194.gz Rev3 MacOSX Snow Leopard 10.6.2 mozilla-central debug test xpcshell on 2011/03/31 07:17:41 s: talos-r3-snow-033 TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_jpakeclient.js | test failed (with xpcshell return code: 0), see following log: TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_jpakeclient.js | {"type":"receiver1","payload":{"gx1":"38C4FD095C18BE4256F8D57505474EF91FA8D91BB68FA73F7C1597C77E80AB2ED4D2EA713664A06AC76412FB7F1A70D73507BD174F7442895F3CF3B0ED0398765CAA32F9F44A2A29370005529541540C9AFC8D48A660CADD6A2F8EF793904BDCBC0DD246CED3BDBC315C43AC1DE662218628935262369341B9C98F67B6DC2E27D3A704FA286BBAC282DB2EC01167D59E6F4C47E405EBD9C98EC13C23B6015C7D6E39C3DCCFEE5D83CFD57DB774FEB144640ED744530BB3C0BDEFDC1C5DB4BD7727176894BF98C5A107C00159954248887650C0B0DD9DFD174564B5796D822DF48901203D5E9F1AA10B811E6EF3D5AE8A82989BAC788D86BA1CDC9ED4149B0FE8666644BFB863E72B208057CEED375BC228A10B5599F771EBDD502A97DDE13D261E688699518B70A69CEE01E1CC146E174AA6F96075619FEA073648E5F04BA27B68E0C82EFD5CB158632483C3489D7557E1169A18C9B3535094E5FAB6745D80837F301B7D41AF54E21A78FFBA993E62228EF5A5C86BD8F8D57C62C8115DD9485F","gx2":"595F485E6512EEA6D286DE6D1A511C745316683E3165F299707CDE8B8B1CEBF8B7319EB394263355BC60CBE70E3C3695FAFC863AB84957874A9E70E87CF39FCCD7BEA8081F12E54D743481A40165892496789E81026B0EB02E4D0F8DEF9601D5135243BADE6C5532B2CC8D7A7A22091A8414C890DC193DC0C9F88D73F12640423E94E5347C1735688FAA908F08D7067CB4F52E9B565659E5F09EA3839ADC5DDA241822748C9BEE3F9CC624C8401A45519273DF438D67B757E6DE9D6F48735A2F9CEA526638CB2EF3D9C2F5236D05DB0AEF8219DDDA9749BFD6FB43A2E6FC754A9C3134D87978E656B8CCDDF9CEAC7B5A4CF60EC32093E95B061AD79FA68031F53E705EAE93F6C4A7F4138E2A6BFA6746D34CCFDBAF4D30AD522842B72419697C3103C9789D3F4FC73BE2484AC64EB70A719A769652BD907035FCF8ED42A6C7198F63FFC4B118F95EE4D252D84CC853A7B06A4472FB0B378D57DAB96FF60442E0834A56B82E283DEBA4BC03B92F7EEB71D60B17BF57B2266DDCF270D60EA0C0DF","zkp_x1":{"gr":"678CFC49E72BD3320FC17EE4721DD242BCAFAD60A9308E1EBB1AD871EAB2CB4DD2D722B0A77953A67945B89B2197AD268EF1F13D6AEF71309B422556C6F38CF377D89421E2C5F71AE7C685663A78A75B1A8B3F055882583D9C69DDC395A94BB7833ABB9DB300AD4DE0FB9A0F5970A48DCF0BBCB8141FEA833380421E596BB364C253BF2D19900247037ECCC23B051508F114E6CFDA9D1357F05C4A6386C71236A69D89919211142E37AA15066F8D2E067CFDE019C6194A8CF951D3E038BBC36B5F9CBAFBA3807C7B6C700693FD4DEDF9B55E9710B915EE3D6349E7B0F427A4F789A1E1C9B6353E87C5B32322F6994A50B0DA68DFF192D0AA9E84687D4B4309D9A20B56FCEC10E11A9065CEB86CD70E318689A239EC64C5688BA7040079E3BB71A18BEAE0735541440AF9A3D054933F4F80040A80F13ECCF95C5CC92C2843BBE15681F22CDAF5CE7BE2E9F8B40A189530A53F790D87837BA7B128E410D8678A3DD8A4D05AFE12B7287A3C14B5DC65BE1416B01867E2A0E2EEC4768E4942B5DC2C","b":"AFF92D98EB4680F768A9FDA017B9CEB544DC1874029919680A77F5377CBE99A7","id":"receiver"},"zkp_x2":{"gr":"63A796D8269CFF0CE56492FAAB5CBF216F4CD92C8E3CC7F4D9D5FA296778DAF5E7AD77D688E7BF705BE7BD26BBA8B8434B22DBEB297657961DBAC3654DA4CBC1DBB16E95EC1EAA755B0A90D37546C7E9C36579BECEEF03090CF57DF7538DEFFE8FD3BC5EEEE1C360B69012A647493989093A14947818B343EFF2DFBFBF48C86DDE33EC8EEC2D5B03EF7E6D890FA2393A7CA070BFD69EF882C55BEB8BB37D3030C50E1134992EDF317F1CD9D1F3BCBBD82356DDF6A51999043F1E1BF0DEEBA6F63357B42C958FE127A1D095DAE31155C8AF86863F71D154F494F4D9E5007C3617ECB4999CE042F651D3BD627DF283F74CBD2E661261A9F43D49F2F9EEFC67F5B27AB7F6A4C97B7F25C05B222A12BF9074CD49B8FE2DF8A4BDC2C6B47B0929E56B9BF087B0C83885AF11A3E242E2C0E6DC4CE0A19DEB19D641171412E964493447DEA121D2103F82772485718C4303914EBACE2754B6A52A5BFD98A5D80126D295D5AC4270D691653A8B429D192DAAA77E8CCD27EA1E9DB9A77CD4934873DA1D02","b":"935FA6690655D4BF73EA80DDA54DD34802128D6FC674993321BCA78272EB2C5D","id":"receiver"}}} == undefined - See following stack: TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_utils_queryAsync.js | test failed (with xpcshell return code: 0), see following log: TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_utils_queryAsync.js | false == true - See following stack:

Comment hidden (Legacy TBPL/Treeherder Robot)

Chris Jones [:cjones] inactive; ni?/f?/r? if you need me

Comment 22

•

14 years ago

For reasons unknown, removing the condition here http://hg.mozilla.org/mozilla-central/file/1a89509e25e4/testing/xpcshell/runxpcshelltests.py#l168, i.e. always turning on tracemalloc backtraces, seems to increase the frequency of the intermittent failure here. It's still intermittent, just more frequent.

Richard Newman [:rnewman]

Assignee

Comment 23

•

14 years ago

(In reply to comment #22) > For reasons unknown, removing the condition here > http://hg.mozilla.org/mozilla-central/file/1a89509e25e4/testing/xpcshell/runxpcshelltests.py#l168, > i.e. always turning on tracemalloc backtraces, seems to increase the frequency > of the intermittent failure here. It's still intermittent, just more frequent. I've also been noticing that test_queryAsync fails much more frequently on my MacBook Pro in the past month (on services-central, which is behind m-c right now). I spent a morning on it, but was unable to narrow it down to anything fixable in the test.

Comment hidden (Legacy TBPL/Treeherder Robot)

Richard Newman [:rnewman]

Assignee

Comment 59

•

14 years ago

Attached patch Proposed patch. v1 (deleted) — Details — Splinter Review

queryAsync's mozIStorageStatementCallback handlers didn't expect to be called both on error and on completion. That led to the callback being called twice -- once to throw the error, and then again with an empty result set. Catching this just right meant that an error would be silently swallowed, resulting in this storm of random orange. The fix is to check the reason code, and return appropriately. I also constantified some things, switched to a query that's guaranteed to fail regardless of the content of the DB, and turned on logging for this test.

Assignee: nobody → rnewman

Status: NEW → ASSIGNED

Attachment #526893 - Flags: review?(philipp)

Philipp von Weitershausen [:philikon]

Comment 60

•

14 years ago

Comment on attachment 526893 [details] [diff] [review] Proposed patch. v1 <3

Attachment #526893 - Flags: review?(philipp) → review+

Richard Newman [:rnewman]

Assignee

Comment 61

•

14 years ago

Landed on m-c to kill oranges fast or your money back: http://hg.mozilla.org/mozilla-central/rev/0e8c23e50c6c Will merge into s-c when I see green, then resolve this bug.

Richard Newman [:rnewman]

Assignee

Comment 62

•

14 years ago

Pushed to s-c.

Status: ASSIGNED → RESOLVED

Closed: 14 years ago

Resolution: --- → FIXED

Philipp von Weitershausen [:philikon]

Comment 63

•

14 years ago

Comment on attachment 526893 [details] [diff] [review] Proposed patch. v1 Requesting Aurora approval for killing a random orange.

Attachment #526893 - Flags: approval-mozilla-aurora?

Comment hidden (Legacy TBPL/Treeherder Robot)

Richard Newman [:rnewman]

Assignee

Comment 65

•

14 years ago

(In reply to comment #64) > Rev3 MacOSX Snow Leopard 10.6.2 mozilla-aurora debug test xpcshell on > 2011/04/19 14:46:17 Exactly :D

JP Rosevear [:jpr]

Comment 66

•

14 years ago

Comment on attachment 526893 [details] [diff] [review] Proposed patch. v1 Because this also touches non-test code and does not impact users, we should live with this for 5.

Attachment #526893 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

Philipp von Weitershausen [:philikon]

Comment 67

•

14 years ago

(In reply to comment #66) > Because this also touches non-test code and does not impact users I should clarify: the problem wasn't actually the test, it's a bug in the code (racing callbacks). That's why it touches non-test code. Users could be impacted by this (the race could occur in production code just as much as in tests.)

Philipp von Weitershausen [:philikon]

Comment 68

•

14 years ago

Comment on attachment 526893 [details] [diff] [review] Proposed patch. v1 Renominating this for Aurora, please see comment 67 for clarified justification.

Attachment #526893 - Flags: approval-mozilla-aurora- → approval-mozilla-aurora?

Johnathan Nightingale [:johnath]

Comment 69

•

14 years ago

Comment on attachment 526893 [details] [diff] [review] Proposed patch. v1 Fast fast, please!

Attachment #526893 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Richard Newman [:rnewman]

Assignee

Comment 70

•

14 years ago

(In reply to comment #69) > Fast fast, please! On it; will land before lunch.

Comment hidden (Legacy TBPL/Treeherder Robot)

Richard Newman [:rnewman]

Assignee

Comment 72

•

14 years ago

Landed on Aurora: http://hg.mozilla.org/mozilla-aurora/rev/0df4f80cdda4

Richard Newman [:rnewman]

Assignee

Updated

•

14 years ago

Target Milestone: --- → mozilla5

Richard Newman [:rnewman]

Assignee

Updated

•

14 years ago

status-firefox5: --- → fixed

Nobody; OK to take it and work on it

Updated

•

12 years ago

Keywords: intermittent-failure

Nobody; OK to take it and work on it

Updated

•

12 years ago

Whiteboard: [orange]

Nobody; OK to take it and work on it

Updated

•

6 years ago

Component: Firefox Sync: Backend → Sync

Product: Cloud Services → Firefox