Closed Bug 618056 Opened 14 years ago Closed 14 years ago

JSOP_NOTRACE should have a default-disabled Trace IC entry

Categories

(Core :: JavaScript Engine, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 617656
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

Details

(Whiteboard: [cib-memory])

When a loop is blacklisted the script's code is mutated to write a JSOP_NOTRACE over the JSOP_TRACE.  The Method JIT treats a jump to a JSOP_NOTRACE like a regular jump, and does not generate a trace IC.  This is a problem if the loop gets blacklisted, compiled, and then unblacklisted, as Unblacklist does not have a trace IC to patch and will do the wrong thing or crash.  This keeps us from being able to discard JIT code for bug 617656.

Instead, a trace IC should be generated for JSOP_NOTRACE, but should be default-disabled, allowing it to be unblacklisted later.
blocking2.0: --- → beta9+
Whiteboard: [cib-memory]
Assignee: general → bhackett1024
Fixed as part of bug 617656.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
No longer blocks: 617656
blocking2.0: beta9+ → betaN+
Blocks: 617656
You need to log in before you can comment on or make changes to this bug.