neil@parkwaycc.co.uk Assignee
	Description • 14 years ago

The star panel contains an unused element. Also the remove bookmark button looks a little out of place at the top of the panel, so I've tried moving it.

	neil@parkwaycc.co.uk Assignee
	Comment 1 • 14 years ago

I also noticed that the "Edit This Bookmark" label was lonely; this seems to be because the icon has no theme, so I added some.

	Ian Neal
	Comment 4 • 14 years ago

Comment on attachment 496790 [details] [diff] [review]
Proposed patch

r=me with the gap at the top of the window fixed. Compare classic with modern - see attached screenshots. Modern's gap is just about acceptable (though ideally could do with an extra pixel or two) but classic it is too small. Though my eyes may be playing tricks on me.

	neil@parkwaycc.co.uk Assignee
	Comment 5 • 14 years ago

(In reply to comment #4)
> r=me with the gap at the top of the window fixed. Compare classic with modern -
> see attached screenshots. Modern's gap is just about acceptable (though ideally
> could do with an extra pixel or two) but classic it is too small. Though my
> eyes may be playing tricks on me.
Particularly as you're using Linux, where arrow panels don't work yet :-(

	Robert Kaiser
	Comment 6 • 14 years ago

Hmm, looking at the screen shots, having "remove" and "cancel" right next to each other sounds dangerous for clicking the wrong thing. Could we have a spring between those two and have "remove" aligned at the start ("right") of the panel instead?

	neil@parkwaycc.co.uk Assignee
	Comment 7 • 14 years ago

(In reply to comment #5)
> Particularly as you're using Linux, where arrow panels don't work yet :-(
Nor do they work in Modern :-(

(In reply to comment #6)
> Hmm, looking at the screen shots, having "remove" and "cancel" right next to
> each other sounds dangerous for clicking the wrong thing. Could we have a
> spring between those two and have "remove" aligned at the start ("right") of
> the panel instead?
Sure, I'll drop a spring in, but start == left, no?

	Robert Kaiser
	Comment 8 • 14 years ago

(In reply to comment #7)
> Sure, I'll drop a spring in, but start == left, no?

Gah, sure, yes, I meant "left". Good that I said "start" as well. ;-)

	neil@parkwaycc.co.uk Assignee
	Comment 9 • 14 years ago

Pushed changeset c671983f52d8 to comm-central.