Closed Bug 61840 Opened 24 years ago Closed 24 years ago

document viewer allocates GC things during finalization

Categories

(Core :: DOM: Core & HTML, defect, P3)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: dbaron, Assigned: jst)

Details

Attachments

(2 files)

If the last release of a document viewer is during JS GC, it causes a JS
assertion because the call to SetStatus and SetDefaultStatus from
GlobalWindowImpl::SetNewDocument leads to a call to js_AllocGCThing.  This also
shouldn't be happening during destruction, since the JS GC could hold the
document viewer well past when the new document is displayed.  We're changing JS
code soon to clear up the tinderbox orange resulting from this...

Perhaps these calls should be moved into DocumentViewerImpl::Stop (from
GlobalWindowImpl::SetNewDocument)?
r=dbaron
Attached patch proposed fix (deleted) — Splinter Review
r=jag
sr=brendan@mozilla.org

And someone needs to fix nsDocumentViewer.cpp so its dtor does not assume where
and when the last Release is called.

/be
dbaron checked this patch in. More to follow?
See patch in bug 61821 for more (regarding brendan's comments).
I believe this is fixed by dbarons checkin, marking FIXED.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified with 2001-020608.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: