Closed
Bug 618515
Opened 14 years ago
Closed 14 years ago
Add moar tests for nsPrompter.
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
nsPrompter could use a few more tests, specifically for checking the default button and default focus in dialogs.
Assignee | ||
Comment 1•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Comment 2•14 years ago
|
||
Backed out due to orange http://hg.mozilla.org/mozilla-central/rev/d0a4697b4b6a
Next time don't let your plant review any code :p
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•14 years ago
|
||
Exciting, I was not expecting Linux to be different than Windows and OS X!
Will investigate.
[Aside: this is why it's good to file bugs even for fairly trivial test-only checkins!]
Assignee | ||
Comment 4•14 years ago
|
||
The failures on Linux are for the window-modal prompts; the focus manager is to be saying nothing is focused (.focusedElement == null), but I'm not sure I believe it (the prompt sure seems to _work_ as if the expected things are focused).
So, I'm going to land this test with a todo() that skips the focused element checking on Linux.
CC'd Enn, maybe you feel like looking at this some time? [It's just a test, I don't believe this is causing any real-world problems.] Oh, I also tried adding a waitForFocus() callback in prompt_common.js's timer observer, but it was never invoking the callback.
Attachment #497012 -
Attachment is obsolete: true
Assignee | ||
Comment 5•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: mozilla2.0b8 → mozilla2.0b10
Comment 6•14 years ago
|
||
Tests that use modal alert windows frequently fail on Fedora Linux. I'd just leave it for now.
You need to log in
before you can comment on or make changes to this bug.
Description
•