Closed
Bug 618726
Opened 14 years ago
Closed 13 years ago
Use Date object's support for ISO8601 dates instead of ISO8601DateUtils.jsm
Categories
(MailNews Core :: Feed Reader, defect)
MailNews Core
Feed Reader
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 7.0
People
(Reporter: philor, Assigned: philor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Since bug 430930 was nice enough to add it.
Attachment #497182 -
Flags: review?(myk)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 497182 [details] [diff] [review]
fix
>- this.mDate = W3CToIETFDate(this.mDate);
>+ this.mDate = new Date(this.mDate).toUTCString();
I wonder if we should now unconditionally convert rather than employing a heuristic to determine whether or not to do so, as new Date(this.mDate).toUTCString() should work on IETF dates too and is probably inexpensive.
Presumably the same change could be made to /mozilla/toolkit/components/feeds/src/FeedProcessor.js as well, after which ISO8601DateUtils.jsm can be removed entirely, although I sure will miss that code, which I really enjoyed writing. :-)
r=myk!
Attachment #497182 -
Flags: review?(myk) → review+
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs push]
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [needs push]
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #497182 -
Attachment is obsolete: true
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in
before you can comment on or make changes to this bug.
Description
•