timeless Assignee
	Description • 14 years ago

1498 nsCookieService::SetCookieStringInternal(nsIURI          *aHostURI,
1503 {

1526   CookieStatus cookieStatus = CheckPrefs(aHostURI, aIsForeign, baseDomain,
1527                                          requireHostMatch, aCookieHeader.get());
1528   // fire a notification if cookie was rejected (but not if there was an error)
1529   switch (cookieStatus) {
1530   case STATUS_REJECTED:
1531     NotifyRejected(aHostURI);

coverity complains that there's a missing break/return/comment <here>. I agree.
It would be clearer to have an extra return here or a comment indicating that we want to continue with the code in STATUS_REJECTED_WITH_ERROR
1532   case STATUS_REJECTED_WITH_ERROR:
1533     return;
1534   default:
1535     break;
1536   }

	dwitte@gmail.com
	Comment 1 • 14 years ago

Patches accepted!

	dwitte@gmail.com
	Comment 3 • 14 years ago

Comment on attachment 497313 [details] [diff] [review]
add return

r=dwitte

	Johnny Stenback (:jst)
	Comment 4 • 14 years ago

Comment on attachment 497313 [details] [diff] [review]
add return

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.

	(no longer active)
	Comment 5 • 14 years ago

http://hg.mozilla.org/projects/cedar/rev/6f30dccd813a

	(no longer active)
	Comment 6 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/6f30dccd813a