Closed
Bug 618800
Opened 14 years ago
Closed 14 years ago
MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches
Categories
(Core :: XML, enhancement)
Core
XML
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
sicking
:
review+
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
130 int MOZ_XMLIsNCNameChar(const char* ptr)
131 {
132 switch (BYTE_TYPE(ptr)) {
133 case BT_NONASCII:
134 if (!IS_NAME_CHAR_MINBPC(ptr)) {
135 return 0;
136 }
please add /* fall through */ here (or just return 1;)
137 case BT_NMSTRT:
138 case BT_HEX:
139 case BT_DIGIT:
140 case BT_NAME:
141 case BT_MINUS:
142 return 1;
143 default:
144 return 0;
145 }
146 }
Summary: MOZ_XMLIsNCNameChar should have a /* fall through */ comment for switch → MOZ_XMLIsNCNameChar and MOZ_XMLIsLetter should have /* fall through */ comments for switches
Attachment #497317 -
Flags: review?(jonas) → review+
Attachment #497317 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 497317 [details] [diff] [review]
add comments
Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #497317 -
Flags: approval2.0? → approval2.0-
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•