Closed
Bug 618830
Opened 14 years ago
Closed 14 years ago
initial assignment to kidNextInFlow is useless in nsTableFrame::ReflowChildren
Categories
(Core :: Layout: Tables, enhancement)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
dbaron
:
approval2.0-
|
Details | Diff | Splinter Review |
2670 nsTableFrame::ReflowChildren(nsTableReflowState& aReflowState,
2674 {
2780 // record the presence of a next in flow, it might get destroyed so we
2781 // need to reorder the row group array
2782 nsIFrame* kidNextInFlow = kidFrame->GetNextInFlow();
either the preceding line should be dropped and the decl moved, or the following line should use 'kidNextInFlow':
2784 if (kidFrame->GetNextInFlow())
2785 reorder = PR_TRUE;
2853 // Special handling for incomplete children
2854 if (NS_FRAME_IS_NOT_COMPLETE(aStatus)) {
2855 kidNextInFlow = kidFrame->GetNextInFlow();
2856 if (!kidNextInFlow) {
2859 rv = presContext->PresShell()->FrameConstructor()->
2860 CreateContinuingFrame(presContext, kidFrame, this, &kidNextInFlow);
2867 mFrames.InsertFrame(nsnull, kidFrame, kidNextInFlow);
2876 rowGroups.InsertElementAt(childX + 1,
2877 static_cast <nsTableRowGroupFrame*>(kidNextInFlow));
2889 }
2890 }
|
||
Updated•14 years ago
|
Attachment #497322 -
Flags: review?(bzbarsky) → review+
Attachment #497322 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 497322 [details] [diff] [review]
proposal a - remove declaration
Please land this after we branch for Gecko 2.0 / Firefox 4.
Attachment #497322 -
Flags: approval2.0? → approval2.0-
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•