Closed
Bug 619230
Opened 14 years ago
Closed 14 years ago
leak test build: "WARNING: The category has no corresponding type!: file ../../../dom/base/nsScriptNameSpaceManager.cpp, line 690"
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: sgautherie, Assigned: mounir)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
peterv
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292348163.1292349259.30746.gz&fulltext=1
Linux mozilla-central leak test build on 2010/12/14 09:36:03
{
WARNING: The category has no corresponding type!: file ../../../dom/base/nsScriptNameSpaceManager.cpp, line 690
}
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292369774.1292372380.30342.gz&fulltext=1
Linux comm-central-trunk leak test build on 2010/12/14 15:36:14
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292367545.1292368633.14869.gz&fulltext=1
OS X 10.6 comm-central-trunk leak test build on 2010/12/14 14:59:05
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1292366108.1292371067.24907.gz&fulltext=1
WINNT 5.2 comm-central-trunk leak test build on 2010/12/14 14:35:08
too.
Reporter | ||
Updated•14 years ago
|
Comment 1•14 years ago
|
||
Mounir: Why do we even have this warning? As far as I can see that observer will get called for new entries for any category, so it's not an error if we are in AddCategoryEntryToHash with an unknown category. In my trunk build I see a ton of warnings for:
The category 'Gecko-Content-Viewers' has no corresponding type!
I think you should remove the warning and just return NS_OK in AddCategoryEntryToHash if the category is not one we care about. You should also move the category check to be the first thing we do in AddCategoryEntryToHash.
Assignee | ||
Comment 2•14 years ago
|
||
Indeed. My bad :(
Updated•14 years ago
|
Attachment #507464 -
Flags: review?(peterv) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #507464 -
Flags: approval2.0?
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 507464 [details] [diff] [review]
Patch v1
[Checked in: See comment 5]
>+ } else {
>+ return NS_OK;
>+ }
Nit: It may be worth documenting this case in the corresponding .h file.
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 507464 [details] [diff] [review]
Patch v1
[Checked in: See comment 5]
Nit: And remove '#include "nsPrintfCString.h"', to fully revert bug 621515.
Updated•14 years ago
|
Attachment #507464 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Reporter | ||
Updated•14 years ago
|
Attachment #507464 -
Attachment description: Patch v1 → Patch v1
[Checked in: See comment 5]
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•