Closed Bug 619641 Opened 14 years ago Closed 14 years ago

jsd should return "anonymous", not an empty string or NULL, for nameless functions, for Firebug compatibility.

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: adrake, Assigned: igor)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(2 files)

Attached file Typical stack trace. (deleted) —
Assertion failure: FUN_FLAT_CLOSURE(callee_fun), at /home/adrake/src/tm/js/src/jsfun.cpp:1178 Steps to reproduce as of tracemonkey df86d5999fef: 0. Disable methodjit and tracejit in about:config. 1. Go to https://bugzilla.mozilla.org/show_bug.cgi?id=618549 2. Enable Firebug and the script panel (tested with 1.7X.0a7) 3. Refresh the page 4. Click the login link if necessary to show the form, then click the login button 5. Observe assertion failure in output A typical stack is attached. With methodjit and tracejit enabled, bug 618549 is triggered.
Setting blocking because it might be the underlying cause of bug 618549.
Blocks: JaegerDebug
blocking2.0: --- → betaN+
Assignee: general → adrake
Bisecting this and bug 618549 yields the revision: changeset: 58521:e35b70ffed69 user: Igor Bukanov <igor@mir2.org> date: Wed Nov 24 17:56:43 2010 +0100 summary: Bug 612150 - Eliminating JS_GetFunctionName. r=mrbkap
Backing this patch out fixes this and bug 618549.
Depends on: 612150
Blocks: 612150
No longer depends on: 612150
The patch in some cases would return an empty string when previously it would return "anonymous" for a function without the name. I guess it lead to fallouts. So a quick fix would be to make sure that the old semantics is preserved.
Assignee: adrake → igor
Attached patch v1 (deleted) — Splinter Review
This is what I am going to test. The patch makes jsd implementation to return "anonymous", not null or empty string, for anonymous functions.
I cannot reproduce the crash. What exactly "script panel" means?
(In reply to comment #7) > Script Panel: > > http://getfirebug.com/wiki/index.php/Script_Panel I will check this tomorrow.
This patch fixes this bug and bug 618549 for me.
Comment on attachment 498272 [details] [diff] [review] v1 I can also see that the patch indeed fixes the issue.
Attachment #498272 - Flags: review?(adrake)
Comment on attachment 498272 [details] [diff] [review] v1 Just in the interest of keeping header dependencies in check, could jsfriendapi.h include just jspubtd.h, and have the cpp pull in whatever private headers it needs?
Attachment #498272 - Flags: review?(adrake) → review+
http://hg.mozilla.org/tracemonkey/rev/a42ff92a089e - pushed without including jsapi.h into jsfriendapi.h
Whiteboard: fixed-in-tracemonkey
Changing the title to reflect the nature of the bug.
Summary: Assertion failure FUN_FLAT_CLOSURE(callee_fun) with Firebug enabled and JIT disabled → jsd should return "anonymous", not an empty string or NULL, for nameless functions, for Firebug compatibility.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: