Alan Thomas Reporter
	Description • 14 years ago

In bug 594996 comment 4, beltzner suggested the harmonization of about: pages that deal with internals/troubleshooting. 

This patch does that, making them all use aboutSupport.css. The affected pages are:

* about:crashes
* about:cache
* about:cache-entry
* about:memory
* about:buildconfig

about:startup needs no changes, and about:plugins is covered in bug 619652.

	Dão Gottwald [:dao]
	Comment 1 • 14 years ago

(In reply to comment #0)
> making them all use aboutSupport.css.

This doesn't make sense. You should add a new file with a name that reflects the actual use.

	Alan Thomas Reporter
	Comment 2 • 14 years ago

(In reply to comment #1)
> This doesn't make sense.

I was modelling this after about:startup (bug 593743), which does in fact apply aboutSupport.css. I will add a patch for about:startup when it re-lands.

I will post a revised patch which uses the filename "chrome://global/skin/diagnostics.css" once I have fixed some tree issues.

	Alan Thomas Reporter
	Comment 3 • 14 years ago

Split into two patches, due to weirdness.

	Stefan [:stefanh]
	Comment 5 • 14 years ago

Alan, you need to pick a reviewer when setting the review? flag (Dao would be the natural choice here, I think)

	Dão Gottwald [:dao]
	Comment 6 • 14 years ago

Comment on attachment 498285 [details] [diff] [review]
Patch part 1, v.2

>+#define APPEND_ROW_CODE(label, value) \

This is unused.

>+  .report-date, .report-time {

nit: generally break the line after the comma

	Alan Thomas Reporter
	Comment 7 • 14 years ago

Thanks for the review, Dão. I will post updated patches once I've fixed the problem I'm having with the part 2 patch (attachment 498286 [details] [diff] [review]). It won't apply without rejections. Does it work for others?

	Alan Thomas Reporter
	Comment 8 • 13 years ago

I have no time to work on this right now.

	Justin Dolske [:Dolske]
	Comment 9 • 13 years ago

Comment on attachment 498286 [details] [diff] [review]
Patch part 2, v.2

Clearing review request per last comment.