Closed Bug 619689 Opened 14 years ago Closed 14 years ago

Intermittent browser_sidebarpanels_click.js | Item is visited followed by a cascade including breaking browser_privatebrowsing_beforeunload_enter.js

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0

People

(Reporter: philor, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch v1.0
(deleted), patch
sdwilsh
: review+
Details | Diff | Splinter Review
Immediately after the Places branch merge, j'accuse http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1292498052.1292499556.31993.gz Rev3 WINNT 6.1 mozilla-central opt test mochitest-other on 2010/12/16 03:14:12 s: talos-r3-w7-019 TEST-START | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Running Bookmarks sidebar test in LTR mode TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | The test node should be successfully selected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | alert dialog observed as expected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFocusManager.setFocus]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: jar:file:///c:/talos-slave/test/build/firefox/omni.jar!/components/nsPrompter.js :: onPromptClose :: line 446" data: no]"] TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Running Bookmarks sidebar test in RTL mode TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | The test node should be successfully selected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | alert dialog observed as expected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFocusManager.setFocus]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: jar:file:///c:/talos-slave/test/build/firefox/omni.jar!/components/nsPrompter.js :: onPromptClose :: line 446" data: no]"] TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Item is visited TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Running History sidebar test in LTR mode TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | The correct visit has been selected TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | The selected node is not bookmarked TEST-PASS | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | The test node should be successfully selected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | alert dialog observed as expected TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFocusManager.setFocus]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: jar:file:///c:/talos-slave/test/build/firefox/omni.jar!/components/nsPrompter.js :: onPromptClose :: line 446" data: no]"] TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Item is visited TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Running History sidebar test in RTL mode TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Console message: [JavaScript Error: "uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryContainerResultNode.getChild]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://browser/content/places/treeView.js :: PTV__getNodeForRow :: line 259" data: no]"] TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Test timed out INFO TEST-END | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | finished in 30134ms TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | Found a tab after previous test timed out: http://mochi.test:8888/browser/browser/components/places/tests/browser/sidebarpanels_click_test_page.html then, later, TEST-START | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js TEST-INFO | chrome://mochitests/content/browser/browser/components/places/tests/browser/browser_sidebarpanels_click.js | alert dialog observed as expected TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | Test timed out TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | Private browsing should be terminated after finishing the test TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | Cleanup function threw an exception - [Exception... "'Failure' when calling method: [nsIPrivateBrowsingService::privateBrowsingEnabled]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/head.js :: <TOP_LEVEL> :: line 6" data: no] INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | finished in 30020ms TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | Found a tab after previous test timed out: data:text/html,<body%20onbeforeunload='return%20false;'>second</body> TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_beforeunload_enter.js | application timed out after 330 seconds with no output browser_privatebrowsing_beforeunload_enter.js would really prefer that browser_sidebarpanels_click.js keep its observations to itself.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1.0 (deleted) — — Splinter Review
I think most of the failure is due to not waiting clear history. But while there I've cleaned up the test because it was pretty hard to follow it.
Attachment #514809 - Flags: review?(sdwilsh)
Comment on attachment 514809 [details] [diff] [review] patch v1.0 r=sdwilsh
Attachment #514809 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/82912051f423
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: