Closed
Bug 61977
Opened 24 years ago
Closed 24 years ago
Webclient hungup when to view source of some pages
Categories
(Core Graveyard :: Java APIs to WebShell, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: avm, Assigned: ashuk)
References
Details
(Keywords: hang, Whiteboard: suntrak-n6)
Attachments
(1 file)
|
(deleted),
text/plain
|
Details |
Webclient hungup, when try to view source of page, that isn't completely loaded.
Steps to reproduce:
1. Start webclient
2. load test.cgi(please see attached) and when 2-3 lines will be
shown select View->Page Source. Note, that webclient hungup on this action.
Reproduced under Intel and Sparc Solaris 2.7 with FCS-candidate(from 11/30/2000)
|
Reporter | |
Comment 1•24 years ago
|
||
|
||
Comment 3•24 years ago
|
||
Adding "freeze" keyword. Not sure if that's correct. Please correct any errors.
Keywords: freeze
|
|
||
Updated•24 years ago
|
|
Assignee | |
Comment 5•24 years ago
|
||
I accept. This might have been fixed because of the culling of deadlocking
calls made by Webclient. Will try to reproduce with latest builds.
Status: NEW → ASSIGNED
|
||
Comment 7•24 years ago
|
||
ViewPageSource function is unavailable in webclien GUI now. There is
only "viewPageSource as String" function.
Thats why I cannot reproduce(not-reproduce) this bug.
|
|
Assignee | |
Comment 8•24 years ago
|
||
Vladimir, The
string ViewPageSource()
function is in keeping with the original Webclient API. This method is
implemented purely in Java and so should not cause any hanging of Mozilla. Pls
test this implementation as it stands and let me know if there are any problems
with it. Otherwise I will be closing this bug.
thanks much.
|
|
||
Comment 9•24 years ago
|
||
Ashu, due to changes in EMWindow.java from version 1.24 to 1.25 "View Page
Source" menu item was changed with "View Page Source as String". And in
function actionPerformed now currentPage.getSource() invoked. But here is
output of webclient:
The Current URL is -- http://www.mozilla.org/projects/blackwood/webclient/
+++++++++++ Page Source is +++++++++++
null<HTML><HEAD> <META HTTP-EQUIV="Content-Type" CONTENT="text/html;
charset=iso-8859-1"> .....
Why the first word of source is null? Is it correct behaviour?
If in actionPerformed I use next code:
byte source[] = EMWindow.this.currentPage.getSourceBytes();
String sou = new String(source);
System.out.println("+++++++++++ Page Source is +++++++++++\n\n" + sou);
I receive the same output.
Can you comment it?
|
|
Assignee | |
Comment 10•24 years ago
|
||
Hi Vladimir,
I have made a small change to CurrentPageImpl.java
----------------------
Index: CurrentPageImpl.java
===================================================================
RCS
file: /cvsroot/mozilla/java/webclient/classes_spec/org/mozilla/webclient/wrapper
_native/CurrentPageImpl.java,v
retrieving revision 1.12
diff -u -r1.12 CurrentPageImpl.java
--- CurrentPageImpl.java 2001/05/08 04:50:29 1.12
+++ CurrentPageImpl.java 2001/05/08 16:39:58
@@ -152,7 +152,7 @@
public String getSource()
{
myFactory.throwExceptionIfNotInitialized();
- String HTMLContent = null;
+ String HTMLContent;
String currURL = getCurrentURL();
System.out.println("\nThe Current URL is -- " + currURL);
try {
@@ -185,7 +185,7 @@
myFactory.throwExceptionIfNotInitialized();
- String HTMLContent = null;
+ String HTMLContent;
String currURL = getCurrentURL();
System.out.println("\nThe Current URL is -- " + currURL);
try {
-------------------
Pls run your test again and let me know if you still see the problem.
|
|
||
Comment 11•24 years ago
|
||
Hi Ashu, may I suggest my patch.
----------------------
Index: CurrentPageImpl.java
===================================================================
RCS
file: /cvsroot/mozilla/java/webclient/classes_spec/org/mozilla/webclient/wrapper
_native/CurrentPageImpl.java,v
retrieving revision 1.12
diff -u -r1.12 CurrentPageImpl.java
--- CurrentPageImpl.java 2001/05/08 04:50:29 1.12
+++ CurrentPageImpl.java 2001/05/08 16:39:58
@@ -152,7 +152,7 @@
public String getSource()
{
myFactory.throwExceptionIfNotInitialized();
- String HTMLContent = null;
+ String HTMLContent = new String();
String currURL = getCurrentURL();
System.out.println("\nThe Current URL is -- " + currURL);
try {
@@ -185,7 +185,7 @@
myFactory.throwExceptionIfNotInitialized();
- String HTMLContent = null;
+ String HTMLContent = new String();
String currURL = getCurrentURL();
System.out.println("\nThe Current URL is -- " + currURL);
try {
-------------------
I cannot compile sources with you patch due to this errors:
org/mozilla/webclient/wrapper_native/CurrentPageImpl.java:170: variable
HTMLContent might not have been initialized
HTMLContent = HTMLContent + line;
^
org/mozilla/webclient/wrapper_native/CurrentPageImpl.java:179: variable
HTMLContent might not have been initialized
return HTMLContent;
^
org/mozilla/webclient/wrapper_native/CurrentPageImpl.java:203: variable
HTMLContent might not have been initialized
HTMLContent = HTMLContent + line;
^
org/mozilla/webclient/wrapper_native/CurrentPageImpl.java:211: variable
HTMLContent might not have been initialized
result = HTMLContent.getBytes();
^
4 errors
I think, HTMLContent variable should be initialized first, in definition.
With my patch both tests passed.
|
|
Assignee | |
Comment 12•24 years ago
|
||
done. patch checked in. thanks Vladimir.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•23 years ago
|
||
Verified with Mozilla 0.9.4 and java sources from 09/18/2001.
|
|
Reporter | |
Comment 14•23 years ago
|
||
Mark verified
|
||
Updated•13 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•