473 obj_toSource(JSContext *cx, uintN argc, Value *vp) 478 JSIdArray *ida; 498 if (!obj || !(he = js_EnterSharpObject(cx, obj, &ida, &chars))) { 500 goto out; there's a condition here, but coverity can't reason it: 502 if (IS_SHARP(he)) { here we assert that !ida is roughly equivalent to IS_SHARP(he): 508 JS_ASSERT(!ida); 517 goto make_string; 518 } here we assert that ida is roughly equivalent to !IS_SHARP(he): 519 JS_ASSERT(ida); if the guard on line 502 is ida (and ida is initialized on 478) then coverity (and friends) should be able to reason that ida isn't leaked in this function.

Comment on attachment 498206 [details] [diff] [review] proposal Review of attachment 498206 [details] [diff] [review]: Sure, ok.