Open
Bug 619784
Opened 14 years ago
Updated 2 years ago
FIX nsCOMPtrs to concrete classes.
Categories
(Toolkit :: Places, defect, P5)
Toolkit
Places
Tracking
()
NEW
People
(Reporter: mak, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Apart specific cases (see http://groups.google.com/group/netscape.public.mozilla.xpcom/browse_frm/thread/77258f1cd7d99773/268b949066f2ba4a?hl=de&q&pli=1) it's not sane to do so, we should do a sweep of the code and fix instances of them.
Reporter | ||
Updated•14 years ago
|
Whiteboard: [places-next-wanted]
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Comment 2•12 years ago
|
||
bug 820672 will simplify the conversion from nsCOMArray<concrete> to the more proper nsTArray<nsRefPtr<concrete>>
Depends on: 820672
Reporter | ||
Comment 3•12 years ago
|
||
Attachment #706778 -
Attachment is obsolete: true
Comment 4•12 years ago
|
||
I really wish we could enforce this through the compiler :(
Reporter | ||
Comment 5•12 years ago
|
||
actually, these uses are "allowed" cause the concrete class implements a single interface, though yes, it would be useful to have compiler checks. Regardless this stuff is there from quite many years, likely from the creation of Places.
Reporter | ||
Comment 6•11 years ago
|
||
not actively working on this atm (And regardless I couldn't finish it without bug 820672)
Assignee: mak77 → nobody
Reporter | ||
Updated•11 years ago
|
Status: ASSIGNED → NEW
Reporter | ||
Updated•11 years ago
|
Whiteboard: [places-next-wanted]
Reporter | ||
Updated•8 years ago
|
Priority: -- → P5
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•