Closed
Bug 620169
Opened 14 years ago
Closed 14 years ago
[@ SVGAnimatedLengthList::SetBaseValueString][@ SVGAnimatedNumberList::SetBaseValueString] useing domWrapper forgetting it might be null
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
timeless
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
49 SVGAnimatedLengthList::SetBaseValueString(const nsAString& aValue)
57 DOMSVGAnimatedLengthList *domWrapper =
58 DOMSVGAnimatedLengthList::GetDOMWrapperIfExists(this);
59 if (domWrapper) {
65 domWrapper->InternalBaseValListWillChangeTo(newBaseValue);
72 rv = mBaseVal.CopyFrom(newBaseValue);
73 if (NS_FAILED(rv)) {
76 domWrapper->InternalBaseValListWillChangeTo(mBaseVal);
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498583 -
Flags: review?(dholbert)
Attachment #498583 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
The same problem exists in SVGAnimatedNumberList, if you care to fix it there too.
|
||
Comment 3•14 years ago
|
||
Comment on attachment 498583 [details] [diff] [review]
patch
r=dholbert, but if it's not too much trouble, please also fix SVGAnimatedNumberList in the same push (or same patch even), as jwatt suggests.
(Many aspects of these files are in sync, so it's nice to fix both places simultaneously when a bug exists in both.)
(I also glanced at SVGAnimatedPointList.cpp and SVGAnimatedPathSegList.cpp, but it looks like they don't need this.)
Attachment #498583 -
Flags: review?(dholbert) → review+
Summary: [@ SVGAnimatedLengthList::SetBaseValueString] uses domWrapper forgetting it might be null → [@ SVGAnimatedLengthList::SetBaseValueString][@ SVGAnimatedNumberList::SetBaseValueString] useing domWrapper forgetting it might be null
Attachment #498583 -
Attachment is obsolete: true
Attachment #498705 -
Flags: review+
Attachment #498705 -
Flags: approval2.0?
Attachment #498583 -
Flags: approval2.0?
Attachment #498705 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Crash Signature: [@ SVGAnimatedLengthList::SetBaseValueString]
[@ SVGAnimatedNumberList::SetBaseValueString]
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•