Closed Bug 620253 Opened 14 years ago Closed 14 years ago

nsResizerFrame::AdjustDimensions fall through comment is misplaced

Categories

(Core :: XUL, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

397 nsResizerFrame::AdjustDimensions(PRInt32* aPos, PRInt32* aSize,
398                                  PRInt32 aMovement, PRInt8 aResizerDirection)
399 {
400   switch(aResizerDirection)
401   {
402     case -1: // only move the window when the direction is top and/or left
403       *aPos+= aMovement;
the comment needs to be between the last statement and the following case, not after the case:
404     case 1: // falling through: the window is resized in both cases
so the comment above is not considered by coverity
405       *aSize+= aResizerDirection*aMovement;
406       if (*aSize < 1) // use one as a minimum size or the element could disappear
407         *aSize = 1;
408   }
Attached patch fix fallthrough comment (deleted) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498671 - Flags: review?(dbaron)
Attachment #498671 - Flags: approval2.0?
Comment on attachment 498671 [details] [diff] [review]
fix fallthrough comment

r=dbaron
Attachment #498671 - Flags: review?(dbaron)
Attachment #498671 - Flags: review+
Attachment #498671 - Flags: approval2.0?
Attachment #498671 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/6b09edde1450
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: