Closed
Bug 620259
Opened 14 years ago
Closed 14 years ago
add fall through comments to nsTableCellMap::SetNotTopStart and rename to nsTableCellMap::ResetTopStart
Categories
(Core :: Layout: Tables, enhancement)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
timeless
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
adding fall through comments helps improve code readability and makes it easier for tools users to identify actual bugs.
928 nsTableCellMap::SetNotTopStart(PRUint8 aSide,
939 switch(aSide) {
940 case NS_SIDE_BOTTOM:
941 aRowIndex++;
add comment
942 case NS_SIDE_TOP:
943 cellData = (BCCellData*)aCellMap.GetDataAt(aRowIndex, aColIndex);
961 break;
962 case NS_SIDE_RIGHT:
963 aColIndex++;
add comment
964 case NS_SIDE_LEFT:
965 cellData = (BCCellData*)aCellMap.GetDataAt(aRowIndex, aColIndex);
973 break;
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498675 -
Flags: review?(bernd_mozilla)
Attachment #498675 -
Flags: approval2.0?
will review over the holidays together with bug 620311 and bug 620312
Comment on attachment 498675 [details] [diff] [review]
add fallthrough comments
bonus points if you rename the funtion from SetNotTopStart to ResetTopStart
Attachment #498675 -
Flags: review?(bernd_mozilla) → review+
Summary: add fall through comments to nsTableCellMap::SetNotTopStart → add fall through comments to nsTableCellMap::SetNotTopStart and rename to nsTableCellMap::ResetTopStart
Attachment #498675 -
Attachment is obsolete: true
Attachment #499504 -
Flags: review+
Attachment #499504 -
Flags: approval2.0?
Attachment #498675 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #499504 -
Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•