Closed
Bug 620280
Opened 14 years ago
Closed 14 years ago
crash [@ XPCJSRuntime::GCCallback] if !self
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file)
|
(deleted),
patch
|
mrbkap
:
review+
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
576 JSBool XPCJSRuntime::GCCallback(JSContext *cx, JSGCStatus status)
577 {
578 XPCJSRuntime* self = nsXPConnect::GetRuntimeInstance();
careful:
579 if(self)
580 {
856 }
oops:
858 nsTArray<JSGCCallback> callbacks(self->extraGCCallbacks);
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498681 -
Flags: review?(mrbkap)
Attachment #498681 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 498681 [details] [diff] [review]
patch
I'd be interested to know if this can actually happen. FWIW, a diff -w would have been nice here. Thanks for patching, though.
Attachment #498681 -
Flags: review?(mrbkap) → review+
|
||
Comment 3•14 years ago
|
||
Comment on attachment 498681 [details] [diff] [review]
patch
Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498681 -
Flags: approval2.0? → approval2.0-
|
||
Comment 4•14 years ago
|
||
This is a nice fix. I agree its not super high priority, but can we make sure we collect these and land them after FF4 and they don't just disappear in the void?
ehsan: in general my patches should be present in a queue i maintain on hg/users:
http://hg.mozilla.org/users/timeless_mozdev.org/mozilla-central-mq/file/default/620280-XPCJSRuntime-GCCallback
appears to be current as it's mentioned in:
http://hg.mozilla.org/users/timeless_mozdev.org/mozilla-central-mq/file/default/series
this of course doesn't guarantee it compiles, but it will apply.
Whiteboard: not-ready → try-patch-from-queue
|
||
Comment 7•14 years ago
|
||
Well, can you make sure that it compiles before I land it? :)
|
|
||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: try-patch-from-queue
Target Milestone: --- → mozilla2.2
|
||
Updated•14 years ago
|
Crash Signature: [@ XPCJSRuntime::GCCallback]
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•