Closed
Bug 620306
Opened 14 years ago
Closed 13 years ago
crash [@ nsFtpState::Init] for oom from BeginWriting()
Categories
(Core :: Networking: FTP, defect)
Core
Networking: FTP
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file)
|
(deleted),
patch
|
Biesinger
:
review+
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
1675 nsFtpState::Init(nsFtpChannel *channel)
1700 char *fwdPtr = path.BeginWriting();
this noble oom check:
1701 if (fwdPtr && (*fwdPtr == '/'))
1702 fwdPtr++;
is immediately defeated:
1703 if (*fwdPtr != '\0') {
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498695 -
Flags: review?(cbiesinger)
Attachment #498695 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 498695 [details] [diff] [review] proposal Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498695 -
Flags: approval2.0? → approval2.0-
|
||
Updated•13 years ago
|
Crash Signature: [@ nsFtpState::Init]
|
||
Comment 3•13 years ago
|
||
Comment on attachment 498695 [details] [diff] [review] proposal Review of attachment 498695 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #498695 -
Flags: review?(cbiesinger) → review+
|
||
Comment 5•13 years ago
|
||
Sent to try: http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=626e32292fdc Assuming all green, will push to inbound after :-)
|
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/13010f8b9fe1
Keywords: checkin-needed
Whiteboard: [inbound]
|
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla9
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/13010f8b9fe1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•