Closed
Bug 620362
Opened 14 years ago
Closed 14 years ago
Uninitialized variable warning in nsNavHistory::InternalAddNewPage
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b11
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
sdwilsh
:
approval2.0+
|
Details | Diff | Splinter Review |
Bug 556631 caused an uninitialized variable warning about pageId.
Flags: in-testsuite-
Attachment #498722 -
Flags: review?(mak77)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 498722 [details] [diff] [review]
Patch v1
is this a scoping issue? we assign it in the subscope before using it in the method, I don't see uses of it before the assignment. Btw the patch looks ok.
Attachment #498722 -
Flags: review?(mak77) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 498722 [details] [diff] [review]
Patch v1
Yeah, my compiler doesn't seem to like nested scopes much.
Attachment #498722 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [build_warning] → [build_warning][needs approval]
|
||
Updated•14 years ago
|
Attachment #498722 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [build_warning][needs approval] → [build_warning]
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
You need to log in
before you can comment on or make changes to this bug.
Description
•