Dão Gottwald [:dao] Assignee
	Description • 14 years ago

Bug 613477 made updates to the star button async and therefore hides the star between the update request and the actual update. That hiding seems unnecessarily noisy and should be avoided.

	Marco Bonardo [:mak]
	Comment 1 • 14 years ago

The alternative would be to disable the star, but disabled status would not be easy to distiguish from not bookmarked status. And a throbber looks exagerated for this case (and perf problematic). Both solutions would still flicker too.

Since the time needed for the update is usually really short, but not predictable, I think we cannot just trust that the user won't click on it before it has been updated.

	Marco Bonardo [:mak]
	Comment 2 • 14 years ago

fwiw, I don't even notice the star unless I am explicitly looking at it, the new gray star is practically invisible to my peripheral view.

	Dão Gottwald [:dao] Assignee
	Comment 3 • 14 years ago

(In reply to comment #1)
> The alternative would be to disable the star, but disabled status would not be
> easy to distiguish from not bookmarked status. And a throbber looks exagerated
> for this case (and perf problematic). Both solutions would still flicker too.

Right, we don't want it to flicker, so why bother at all? Just disable it without actually styling it disabled.

	Marco Bonardo [:mak]
	Comment 4 • 14 years ago

I think the solution was discarded because a click op on it in this "special" state would be completely no-op, it would just appear as a broken piece of UI. But we can re-evaluate that solution if ux is fine with that.

	Marco Bonardo [:mak]
	Comment 5 • 14 years ago

also, Ideally it should not flicker when switching tabs even with async since status is cached, so that could be the real bug to fix.

	Dão Gottwald [:dao] Assignee
	Comment 6 • 14 years ago

(In reply to comment #4)
> I think the solution was discarded because a click op on it in this "special"
> state would be completely no-op, it would just appear as a broken piece of UI.

This seems like an extreme edge case not worth optimizing for.

(In reply to comment #5)
> also, Ideally it should not flicker when switching tabs even with async since
> status is cached, so that could be the real bug to fix.

I actually noticed this at first when going back (using bfcache).

	Dão Gottwald [:dao] Assignee
	Comment 7 • 14 years ago

Btw, what happens if a user hits Ctrl+D while the star is updating? This case, while still an edge case, might be slightly easier to hit than clicking the star button while it's updating. To handle that I think you really want to disable the command.

	Dão Gottwald [:dao] Assignee
	Comment 9 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/5d7d04e98fa9