Closed
Bug 620896
Opened 14 years ago
Closed 14 years ago
Popup notification button size is off when DirectWrite is disabled
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b9
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: kontakt, Assigned: dao)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre
Split button wrong size with d2d disable:
http://img257.imageshack.us/img257/4269/withoutdirect2d.png
And enabled:
http://img821.imageshack.us/img821/530/withdirect2d.png
(also notice different sizes of browser UI elements)
Reproducible: Always
Steps to Reproduce:
1. Enter about:config
2. Switch gfx.direct2d.disabled setting.
3. Restart browser.
|
||
Updated•14 years ago
|
Whiteboard: dupeme
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Component: General → Themes
Ever confirmed: true
Product: Firefox → Toolkit
QA Contact: general → themes
|
|
Assignee | |
Updated•14 years ago
|
Blocks: 577928
Summary: Arrowpanel/doorhanger wrong spit button size (direct2d) → Popup notification button size is off when DirectWrite is disabled
Whiteboard: dupeme
|
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #500657 -
Flags: review?(gavin.sharp)
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #500657 -
Flags: review?(neil)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 500657 [details] [diff] [review]
patch
This looks reasonable for Windows Classic and Linux, which is all I can test.
> .popup-notification-menubutton > .button-menubutton-button {
>-%ifdef WINSTRIPE_AERO
>- padding: 0;
>-%else
>- padding: 2px 0;
>-%endif
>+ padding-top: 0;
>+ padding-bottom: 0;
[Possibly this can go, since I can't seem to find any existing padding.]
Attachment #500657 -
Flags: review?(neil) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #500657 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 3•14 years ago
|
||
> > .popup-notification-menubutton > .button-menubutton-button {
> >-%ifdef WINSTRIPE_AERO
> >- padding: 0;
> >-%else
> >- padding: 2px 0;
> >-%endif
> >+ padding-top: 0;
> >+ padding-bottom: 0;
> [Possibly this can go, since I can't seem to find any existing padding.]
true!
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in
before you can comment on or make changes to this bug.
Description
•