Closed
Bug 621161
Opened 14 years ago
Closed 14 years ago
add (void) to markIfUnmarked() in js::gc::TypedMarker
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: igor)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
igor explains that this is safe but offers to add a comment explaining in addition to a (void) annotation
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #499515 -
Flags: review?(timeless)
Comment on attachment 499515 [details] [diff] [review]
v1
> the children marking
do you mean "marking the children" or "the children marking phase"? I think you probably should use one of those, r=me for one of them :)
Attachment #499515 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 499515 [details] [diff] [review]
v1
Nominating for 2.0: this is an annotation-only patch to help with coverity
analysis.
Attachment #499515 -
Flags: approval2.0?
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 6•14 years ago
|
||
Comment on attachment 499515 [details] [diff] [review]
v1
Has landed already, so clearing redundant approval2.0?, since it's causing this fixed bug to erroneously appear under approval requests here:
http://office.smedbergs.us/blocker-report/
Attachment #499515 -
Flags: approval2.0?
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•