Closed Bug 621344 Opened 14 years ago Closed 14 years ago

Displaying print preview stacks app tabs

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b9
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: charette.s, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

stacked app tabs after print preview
(deleted), image/png
Details
patch
(deleted), patch
Dolske
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101224 Firefox/4.0b9pre Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101224 Firefox/4.0b9pre When accessing the print preview from the file menu (or the global menu when menu bar is hidden) while having app tabs they're all stacked together when coming back to browsing context. Reproducible: Always Steps to Reproduce: 1. Have at least one app tab 2. Enable print preview 3. Close print preview Actual Results: App tabs are all stacked Expected Results: App tabs shouldn't be stacked
Added version info since i couldn't from the firefox page.
Version: unspecified → Trunk
Attached image stacked app tabs after print preview (deleted) —
Opening a new tab fix the issue.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
Reproducible with latest trunk (from 2010-12-24).
Regression window: Works: http://hg.mozilla.org/mozilla-central/rev/52b229f6a051 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre ID:20101221150740 Fails: http://hg.mozilla.org/mozilla-central/rev/3e4f01f2a119 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101221 Firefox/4.0b9pre ID:20101221155836 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=52b229f6a051&tochange=3e4f01f2a119
Blocks: 617522
Keywords: regression
blocking2.0: --- → ?
Target Milestone: --- → Firefox 4.0
Assignee: nobody → dao
Target Milestone: Firefox 4.0 → ---
blocking2.0: ? → betaN+
Attached patch patch (deleted) — — Splinter Review
The real problem here is that app tabs can't be positioned while the tab bar is hidden, but I don't think that's worth worrying about. Ideally print preview just shouldn't add a temporary tab (e.g. by fixing bug 133787).
Attachment #501000 - Flags: review?(dolske)
Attachment #501000 - Flags: review?(dolske) → review+
http://hg.mozilla.org/mozilla-central/rev/31244b5fd7d2
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
I am still seeing this problem in a clean profile the Jan 05 nightly, BuildID=20110105030550 changeset d2bd42931b03 Mozilla/5.0 (Windows NT 6.1; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre
Same on Windows with Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20110105 Firefox/4.0b9pre => Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
It maybe just that this patch (changeset 31244b5fd7d2) was pushed after the changeset for the nightly build (d2bd42931b03). For me on Win7 this is fixed in the latest hourly cset(257af9cad364) BuildID=20110105062111 This will be included in tomorrows nightly. Can be marked fixed again.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20110107 Firefox/4.0b9pre Is there a way to test this via an automated test?
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
I confirm it's fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: