Closed
Bug 622390
Opened 14 years ago
Closed 3 years ago
Let SimpleTest.js dump()s test results when run without TestRunner.js
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
INACTIVE
People
(Reporter: sgautherie, Unassigned)
References
()
Details
Attachments
(1 file, 1 obsolete file)
This bug is +/- like bug 456876, but doesn't care about --log-file (or --console-level) support.
It's different than bug 508664 as I'll just keep the full standalone mode (which can be useful to develop/debug a test).
In other words, I'll submit a trivial fix for the current behavior, which could be revisited in that bug if need be.
Reporter | ||
Comment 1•14 years ago
|
||
Attachment #500645 -
Flags: review?
Reporter | ||
Updated•14 years ago
|
Attachment #500645 -
Flags: review? → review?(rcampbell)
Reporter | ||
Updated•14 years ago
|
Comment 2•14 years ago
|
||
Comment on attachment 500645 [details] [diff] [review]
(Av1) Add and use a fake SimpleTest._logger object, Move SimpleTest._logEnabled checks into SimpleTest._logResult()
from SimpleTest.js:
11 * NOTE: Pay attention to cross-browser compatibility in this file. For
12 * instance, do not use const or JS > 1.5 features which are not yet
13 * implemented everywhere.
dump() is not implemented in all browsers.
I'm not sure I understand why this bug is required. Please why you need to run this without the test runner.
Attachment #500645 -
Flags: review?(rcampbell) → review-
Reporter | ||
Comment 3•14 years ago
|
||
Av1, with comment 2 suggestion(s).
(In reply to comment #2)
> dump() is not implemented in all browsers.
Well, it is already used in this file and in TestRunner+setup, so I'm just doing the same.
> I'm not sure I understand why this bug is required. Please why you need to run
> this without the test runner.
This is the current/usual way to run one test only, to develop/debug it...
Attachment #500645 -
Attachment is obsolete: true
Attachment #501074 -
Flags: review?(rcampbell)
Comment 4•14 years ago
|
||
Comment on attachment 501074 [details] [diff] [review]
(Av2) Use a console Logger (copied from setup.js), Move SimpleTest._logEnabled checks into SimpleTest._logResult()
usual for whom? I usually run:
TEST_PATH=path/to/my/test.js make mochitest-browser-chrome
or similar. I recommend others do the same.
As for inclusion of dump() elsewhere in the file, I guess I missed that. Should probably update the header comment to reflect that or change the dump to do the right thing on other browsers.
In any case, I don't see a lot of value in this patch. What we have now works well enough.
Attachment #501074 -
Flags: review?(rcampbell) → review-
Reporter | ||
Comment 5•10 years ago
|
||
Note (to self): check current status, after bug 1014062 (for example).
Comment 6•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months and this bug has severity 'major'.
:ahal, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(ahal)
Updated•3 years ago
|
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(ahal)
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•