Closed
Bug 623137
Opened 14 years ago
Closed 14 years ago
Failed to build jsdbgapi.cpp with --disable-methodjit
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 623277
People
(Reporter: ginnchen+exoracle, Assigned: sfink)
References
Details
Attachments
(1 file)
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
+ if (!script->singleStepMode == !singleStep)
+ return JS_TRUE;
singleStepMode is only defined with JS_METHODJIT.
Assignee | ||
Updated•14 years ago
|
Assignee: general → sphink
OS: Mac OS X → All
Hardware: x86 → All
Comment 1•14 years ago
|
||
Fixes (this instance of) build bustage and a related warning.
Sorry for the steal, sfink! I saw the bug and made the patch and when I came back you had taken it. With this patch, bug 623139 's patch, and another build failure (bug forthcoming) the --disable-methodjit shell builds and passes tests.
Updated•14 years ago
|
Attachment #501367 -
Flags: review?(sphink)
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 501367 [details] [diff] [review]
Patch v0
Thanks! I was still messing around with my build environment anyway.
Attachment #501367 -
Flags: review?(sphink) → review+
Comment 3•14 years ago
|
||
The other bug I mentioned is bug 623277 .
Assignee | ||
Comment 4•14 years ago
|
||
A different fix was already applied as part of bug 622503, and I'm consolidating these --disable-methodjit bugs.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•