http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1294237594.1294240298.5073.gz Rev3 MacOSX Snow Leopard 10.6.2 tryserver debug test mochitest-other on 2011/01/05 06:26:34 { 177 ERROR TEST-UNEXPECTED-FAIL | SimpleTest._logResult() | Next log line was cut because its length was too long (27114 > 16384): fix the test! 178 INFO TEST-PASS | chrome://mochitests/content/chrome/content/xul/content/test/test_bug398289.html | persistent attribute in tab box broken, expected: data:image/png;base64,iVBORw0KGgoAAAANSUh [...] }

Maybe just turn this test to |ok(snap1 == snap2)| and if it fails dump the values with |if (snap1 != snap2) { is(snap1, snap2) }| to have the snaps in the log?

Maybe like this?

Comment on attachment 502811 [details] [diff] [review] v1 (In reply to comment #2) > Maybe like this? This certainly fixes the expected and usual case of the test passing :-) Yet, I believe (half of) the issue remains in the not-passing case :-| There is a discussion (now) going on in bug 621390...

Serge, any news here?

Comment on attachment 502811 [details] [diff] [review] v1 Review of attachment 502811 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Honza Bambas (:mayhemer) from comment #4) > Serge, any news here? As bug 621390 is fully stalled, let's try and improve this test log here. But something seems to have silently broken in the meantime: should fix this first/too :-/ https://tbpl.mozilla.org/php/getParsedLog.php?id=10169475&tree=Firefox&full=1 Rev4 MacOSX Snow Leopard 10.6 mozilla-central opt test mochitest-other on 2012-03-18 16:48:16 PDT for <a href="../?branch=mozilla-central&rev=58a2cd0203ee">push 58a2cd0203ee { 1822 INFO TEST-PASS | chrome://mochitests/content/chrome/content/xul/content/test/test_bug398289.html | persistent attribute in tab box broken, expected: undefined got: undefined } ::: content/xul/content/test/test_bug398289.html @@ +31,5 @@ > > var equal, str1, str2; > [equal, str1, str2] = compareSnapshots(snap1, snap2, true); > > + ok(equal, "persistent attribute in tab box broken"); Add + (equal ? "" : ". (See following screenshots:)") @@ +33,5 @@ > [equal, str1, str2] = compareSnapshots(snap1, snap2, true); > > + ok(equal, "persistent attribute in tab box broken"); > + if (!equal) { > + // put the screenshots to the test log: "Dump ..." @@ +35,5 @@ > + ok(equal, "persistent attribute in tab box broken"); > + if (!equal) { > + // put the screenshots to the test log: > + ok(false, "Expected: " + str1); > + ok(false, "Got: " + str2); Use dump(): less bloat in brief log and counts, still easy to access with the "ok(equal, ...);" link. Ftr, wrt "too long (27114 > 16384)", these should indeed output not "too" long lines ;-)