Doug Turner (:dougt) Assignee
	Description • 14 years ago

fennec will not ship IndexedDB in 4.0.  we need a prefable way of removing it from content similar to what we did with desktop notifications in firefox desktop.

	Doug Turner (:dougt) Assignee
	Comment 1 • 14 years ago

ben, jst suggested this approach.  Basically create a new interface for the indexedDB getter, and mark the existing one noscript.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 2 • 14 years ago

You should probably cache the return value of nsContentUtils::GetBoolPref().

	Doug Turner (:dougt) Assignee
	Comment 3 • 14 years ago

jst, bent suggested to just drop the old method.  any objections?

	Ben Turner (not reading bugmail, use the needinfo flag!)
	Comment 4 • 14 years ago

Comment on attachment 501717 [details] [diff] [review]
patch v.1

>+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMStorageIndexedDB)
>     DOM_CLASSINFO_MAP_ENTRY(nsIDOMModalContentWindow)

I don't think ModalContentWindow needs IndexedDB...

>+nsGlobalWindow::GetOldIndexedDB(nsIIDBFactory** _retval)

Hopefully we can combine the getters on both interfaces to avoid this one in C++.

>+  static bool HasIndexedDBSupport() {
>+    return nsContentUtils::GetBoolPref("indexedDB.feature.enabled", PR_TRUE);

I'd actually default to PR_FALSE.

	Ben Turner (not reading bugmail, use the needinfo flag!)
	Comment 5 • 14 years ago

Comment on attachment 501717 [details] [diff] [review]
patch v.1

Oh, and I was totally wrong earlier, I don't think we need to optimize the pref getter with a cache variable because nsDOMClassInfo::Init is only called once per app run. Before I thought that code would run every time we used the classinfo. Oops.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 6 • 14 years ago

(In reply to comment #4)
> Comment on attachment 501717 [details] [diff] [review]
> patch v.1
> 
> >+    DOM_CLASSINFO_MAP_ENTRY(nsIDOMStorageIndexedDB)
> >     DOM_CLASSINFO_MAP_ENTRY(nsIDOMModalContentWindow)
> 
> I don't think ModalContentWindow needs IndexedDB...
Why not?

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 7 • 14 years ago

(In reply to comment #5)
>  earlier, I don't think we need to optimize the pref
> getter with a cache variable because nsDOMClassInfo::Init is only called once
> per app run.
Ah,  good. This is the information I was asking on IRC.

	Ben Turner (not reading bugmail, use the needinfo flag!)
	Comment 9 • 14 years ago

Comment on attachment 502552 [details] [diff] [review]
patch v.2

Can you add a comment to nsIDOMStorageWindow saying that the mozIndexedDB getter should be removed post-2.0?

	Doug Turner (:dougt) Assignee
	Comment 10 • 14 years ago

http://hg.mozilla.org/mozilla-central/rev/477494ee0f88

	Aakash Desai [:aakashd]
	Comment 11 • 14 years ago

Are there any user-facing issues to test around with this landing, doug?

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 12 • 14 years ago

For Firefox, nothing should have changed. For Fennec, there should no longer be a "mozIndexedDB" property on window/the global object.