After applying the patch from bug# 617272 to storage-backport compilation fails with error: ...C_BUILD=1 -DMOZ_STATIC_MAIL_BUILD=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DBUILD_CTYPES=1 -DMOZ_MORK=1 -DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DMOZ_ACCESSIBILITY_ATK=1 -DATK_MAJOR_VERSION=1 -DATK_MINOR_VERSION=12 -DATK_REV_VERSION=3 -D_COMM_CONFIG_H_ -DMOZILLA_CLIENT /home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp "../../mozilla/dist/include/mozilla/Mutex.h", line 66.27: 1540-0198 (W) The omitted keyword "private" is assumed for base class "BlockingResourceBase". "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 142.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 152.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 160.1: 1540-0129 (S) The qualifier "AsyncBindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 169.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 182.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 190.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 196.1: 1540-0129 (S) The qualifier "AsyncBindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 242.3: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 242.3: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 242.3: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 252.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 274.1: 1540-0129 (S) The qualifier "AsyncBindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 295.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 309.1: 1540-0129 (S) The qualifier "AsyncBindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 321.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 331.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 341.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 351.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 361.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 371.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 380.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 396.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 409.1: 1540-0129 (S) The qualifier "AsyncBindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 423.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 433.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 443.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 453.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 463.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 473.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 482.1: 1540-0129 (S) The qualifier "BindingParams" is not defined in the current scope. "/home/ulink/src/comm-1.9.2/storage-backport/src/mozStorageBindingParams.cpp", line 498.1: 1540-0063 (S) The text "}" is unexpected. gmake[2]: *** [mozStorageBindingParams.o] Error 1 gmake[2]: Leaving directory `/home/ulink/src/comm-1.9.2/obj-tb3-opt/storage-backport/src' gmake[1]: *** [libs] Error 2 gmake[1]: Leaving directory `/home/ulink/src/comm-1.9.2/obj-tb3-opt/storage-backport' gmake: *** [default] Error 2 b

The compilation error above resulted from not removing the original closing the anonymous namespace. manually resolved similar to https://bugzilla.mozilla.org/show_bug.cgi?id=617272

Moving to Thunderbird and out of storage, as this is a Thunderbird build thing.

storage-backport is a Thunderbird 3.1.x only build thing. Is there an effort under way to package Thunderbird 3.1.x?

(for AIX)

(In reply to comment #3) > storage-backport is a Thunderbird 3.1.x only build thing. Is there an effort > under way to package Thunderbird 3.1.x? Yes. Firefox 3.6.x port is ready, so Thunderbird 3.1 is going to replace tb3.0 now.

Comment on attachment 501639 [details] [diff] [review] removing static and wrapping into anonymous namesspace instead Patch looks fine, builds on the try server per human inspection of the logs (comm-1.9.2 does not really work on try-comm-central in terms of green/red/orange anymore).

asuth: thx for turbo fast review :-)

the 1.9.2 branch patch from bug# 617272 landed yesterday without problems in mozilla-1.9.2 repository.

Checked in: http://hg.mozilla.org/releases/comm-1.9.2/rev/0b57d83aa280