User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8 Build Identifier: config_modify_panels hook can be used to add new parameters Reproducible: Always

AFAICT, the problem is that Bugzilla::Config::_load_params(), which is called by checksetup.pl via update_params(), passes $hook_panels to the config_modify_panels hook after @param_list has been populated, making it ignoring newly added parameters. I'm not sure why Config.pm uses both %params and @param_list as shared variables. This module probably needs some cleanup.

Comment on attachment 502555 [details] [diff] [review] patch, v1 >Index: Bugzilla/Config.pm >+ if (!$params{$item}) { >+ $oldparams{$item} = delete $param->{$item}; > } That needs to be !exists (the param's value could be 0). Otherwise this looks fine! You can fix the above on checkin. :-) We also should really get rid of "our %params" and use request_cache instead....

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Config.pm Committed revision 7653.

Considering this blocks bug 284570, I'd like to get this on Bugzilla 4.0. I highly doubt there are any current extensions for 4.0 that will be broken as a result of this change.

Bug 284570 will be implemented as an extension, and on trunk only. So you don't need it on this branch, based on this argument.

Yeah, agreed with LpSolit. You are welcome to backport this hook if you feel that doing so would be an appropriate decision.

The hook needs to add parameter description as well

Oh, that would be a different bug, if it's required. (Template hooks are separate from code hooks.)

Added to relnotes in bug 713346.