Closed
Bug 624798
Opened 14 years ago
Closed 13 years ago
nsBidiPresUtils should not keep state as member variables
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: smontagu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See bug 624722 comment 4.
|
Assignee | |
Comment 1•14 years ago
|
||
This applies on top of the patches in bug 263359
Comment on attachment 519654 [details] [diff] [review]
Patch
This review is a bit rubber-stamp-y but it looks good to me.
+ nsBidi* mBidiEngine;
nsAutoPtr
Some of the nsTArrays should probably be nsAutoTArray.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #519654 -
Attachment is obsolete: true
Attachment #523097 -
Flags: review?(roc)
Attachment #519654 -
Flags: review?(roc)
Attachment #523097 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Version: Trunk → Other Branch
|
|
Assignee | |
Comment 5•14 years ago
|
||
Backed out in http://hg.mozilla.org/mozilla-central/rev/fa0295a97f1b because of bug 650189
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 6•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•