Serge Gautherie (:sgautherie) Reporter
	Description • 14 years ago

      No description provided.

	Serge Gautherie (:sgautherie) Reporter
	Comment 1 • 14 years ago

This fixes bug 625038, after fixing bug 625114 too.
I'll land this when the latter is fixed only...

This code is mostly copied from FF, with some nits fixed.
The only points I wondered about:
*does the code belongs in navigator.js (and not browser.js)?
*should I s/gBrowser/getBrowser/ there?

	Serge Gautherie (:sgautherie) Reporter
	Comment 2 • 14 years ago

Comment on attachment 503215 [details] [diff] [review]
(Av1) Just port it, Remove an obsolete comment

(In reply to comment #1)
> The only points I wondered about:

And "do we need an extra check or something to be safe on the mailnews side?".

	neil@parkwaycc.co.uk
	Comment 4 • 14 years ago

Comment on attachment 503215 [details] [diff] [review]
(Av1) Just port it, Remove an obsolete comment

This is missing a swathe of XBL changes, both tabbrowser and notificationbox.

> 
> 
Nit: don't need two consecutive blank lines

>+  let foundBrowser = gBrowser.getBrowserForDocument(aWindow.document);
[What happens if a frame alerts?]

>+            let browser = aBrowser || this.mCurrentBrowser;
Nit: should put tab here, it doesn't change between prompts.

>+                let tab = self._getTabForContentWindow(browser.contentWindow);
Someone mentioned on one of the session store bugs that we need a getTabForBrowser function (session store has an internal version) which Gavin suggested could use the uniqueID (browser.id == tab.linkedPanel).

>+                let count = parseInt(browser.getAttribute("tabmodalPromptShowing")) - 1;
Nit: The - operator already does a parse (ok, so it's a parseFloat...)

>+              listPrompts : function(aPrompt) {
[Unused parameter?]

>+                // NodeList --> real JS array
There's a function for that, although I forget it offhand.

	Justin Dolske [:Dolske]
	Comment 5 • 14 years ago

Comment on attachment 503235 [details] [diff] [review]
(Bv1-FF) Fix some nits

As far as I can see this is just nitpicky style churn.

	Justin Wood (:Callek)
	Comment 6 • 13 years ago

Looks like Serge dropped this, and it is of HIGH value to our users, removes our DOS strike-area.

Firefox has had this feature since Fx4.

Ewong, does this look like something you'd be capable/willing to take on, (it is more advanced than your average bug)

	Serge Gautherie (:sgautherie) Reporter
	Comment 7 • 13 years ago

(In reply to comment #6)
> Looks like Serge dropped this,

Yes. Iiuc, this +/- depend(ed) on bug 625114, which in turn...
These seemed too complicated wrt my limited skill in this area.
(And I currently don't have much free time (to spend on Moz/SM) :-|)

	Philip Chee
	Comment 8 • 12 years ago

>>+                // NodeList --> real JS array
> There's a function for that, although I forget it offhand.
Array.slice() ?