Closed
Bug 625329
Opened 14 years ago
Closed 13 years ago
Pinned tabs are used when setting homepage from current tabs
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: fasdfasdas, Assigned: zpao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
When you click "use opened tabs" for settings homepage in preferences menu, it counts application tab as normal tab and adds it too but when you restart the browser it opens 3 tabs, one app tab, one tab with same url as app tab, one tab with actual homepage.
Reproducible: Always
Steps to Reproduce:
1.make an app tab and normal tab
2.go pref. menu and click use current tabs to set homepage
3.save and restart
Actual Results:
Application tab left acting the same way it does, I got two new tabs on startup.
Expected Results:
Application tab should be a constant homepage-like URL on startup instead of the page I was at before closing Firefox.
Comment 1•14 years ago
|
||
Confirmed on trunk.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hardware: x86_64 → x86
Version: unspecified → Trunk
Comment 2•14 years ago
|
||
setHomePageToCurrent does not seem to be aware of tabs and visibleTabs and so on, so it's also probably misbehaving with Panorama.
Probably it should use visibleTabs and ignore apptabs, adding uiwanted to define this.
Blocks: pinnedtabs
Keywords: uiwanted
Comment 3•14 years ago
|
||
Confirm this on
Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110118 Firefox/4.0b10pre
Comment 4•14 years ago
|
||
This is happening so far as Fx4b6 candidate builds | all platforms
Assignee | ||
Comment 5•13 years ago
|
||
Bug 636149 made it so only visible tabs are used, but pinned tabs are still included.
Assignee | ||
Comment 6•13 years ago
|
||
Assignee: nobody → paul
Attachment #552529 -
Flags: review?(gavin.sharp)
Comment 7•13 years ago
|
||
Comment on attachment 552529 [details] [diff] [review]
Patch v0.1
>diff --git a/browser/components/preferences/main.js b/browser/components/preferences/main.js
>+ let _this = this;
>+ window.addEventListener("focus", function() _this._updateUseCurrentButton(), false);
Use .bind()?
>+ _getTabsForHomePage: function ()
>- if (win && win.document.documentElement
>- .getAttribute("windowtype") == "navigator:browser") {
Isn't this check still needed to catch the cases where .opener is not a browser window? The previous logic didn't needed it for the command case since the button was disabled then.
Attachment #552529 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Updated•13 years ago
|
Keywords: uiwanted
OS: Windows 7 → All
Hardware: x86 → All
Summary: application tab is considered as normal while settings homepage → Pinned tabs are used when setting homepage from current tabs
Assignee | ||
Comment 8•13 years ago
|
||
Addressed comments.
Attachment #552529 -
Attachment is obsolete: true
Attachment #575227 -
Flags: review?(gavin.sharp)
Comment 9•13 years ago
|
||
Comment on attachment 575227 [details] [diff] [review]
Patch v0.2
Can't lost the window.opener null check in _getTabsForHomePage, since that isn't guaranteed to be non-null.
Attachment #575227 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Comment 10•13 years ago
|
||
Ah, I was being a bit naive there and assumed the only situation left was where the pref window is opened from another window.
Attachment #575227 -
Attachment is obsolete: true
Attachment #575277 -
Flags: review?(gavin.sharp)
Updated•13 years ago
|
Attachment #575277 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 11•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 12•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 11
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•