Closed
Bug 625478
Opened 14 years ago
Closed 14 years ago
First paint timestamp is broken on OSX and Android
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mossop, Assigned: taras.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
Bug 522375 attempts to report when the first paint happened but it doesn't work on OSX or Android.
|
||
Comment 1•14 years ago
|
||
I think this is because the first paint time is captured in the view manager for an NS_DID_PAINT event. We don't send NS_DID_PAINT events in all platforms.
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #1)
> I think this is because the first paint time is captured in the view manager
> for an NS_DID_PAINT event. We don't send NS_DID_PAINT events in all platforms.
Is there a better place to hook into?
|
|
||
Comment 4•14 years ago
|
||
I think in nsViewManager::RenderViews after the mObserver->Paint call should be a good place.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Assignee: nobody → tglek
Attachment #503647 -
Flags: review?(tnikkel)
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 503647 [details] [diff] [review]
better firstpaint hook
>@@ -447,6 +447,8 @@ void nsViewManager::RenderViews(nsView *
> mObserver->Paint(displayRoot, aView, aWidget, region, aIntRegion,
> aPaintDefaultBackground, aWillSendDidPaint);
> }
>+ if (!gFirstPaintTimestamp)
>+ gFirstPaintTimestamp = PR_Now();
> }
Nit: you might want to put this inside the "if (mObserver)" block, if we don't call Paint then we aren't painting anything at all. r+ with that change.
Attachment #503647 -
Flags: review?(tnikkel) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #503647 -
Attachment is obsolete: true
Attachment #503660 -
Flags: approval2.0?
|
Reporter | |
Updated•14 years ago
|
Attachment #503660 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•