Closed
Bug 626539
Opened 14 years ago
Closed 14 years ago
GtkPaperSize leak in nsDeviceContextSpecGTK::Init()
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: karlt, Assigned: karlt)
References
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
standardGtkPaperSize is freed only in the else block. There is no free in the normal case when paper sizes match. http://hg.mozilla.org/mozilla-central/annotate/7a3469118cf3/widget/src/gtk2/nsDeviceContextSpecG.cpp#l545
|
Assignee | |
Comment 1•14 years ago
|
||
gtk_print_settings_set_paper_size doesn't retain the GtkPaperSize but merely copies information out of it. gtk_page_setup_set_paper_size makes a copy of the GtkPaperSize.
Attachment #504584 -
Flags: review?(roc)
Attachment #504584 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
I assume this is a small leak and so this can wait for 2.next.
Depends on: post2.0
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a593739bfbca
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
No longer depends on: post2.0
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•