Closed
Bug 626666
Opened 14 years ago
Closed 9 years ago
Style Panorama search + exit buttons according to Sean's mockup
Categories
(Firefox Graveyard :: Panorama, defect, P4)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mitcho, Unassigned)
References
Details
(Whiteboard: [visual][polish])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Bug 597269 put the Panorama search and exit buttons together, but styled the independently of our design mockup.
We should modify the pinstripe panorama styles to better match the button CSS here: http://mozilla.seanmartell.com/tabcandy/
Reporter | ||
Updated•14 years ago
|
Whiteboard: [panorama]
Updated•14 years ago
|
Component: Theme → TabCandy
QA Contact: theme → tabcandy
Comment 1•14 years ago
|
||
My bad! I styled it to be exactly like the groups css intentionally.
Comment 2•14 years ago
|
||
Note that we want the "raised" look shown in that web page (the bottom two buttons on the right), but we want to keep them together as they are now. You should be able to lift the css straight off that page.
Sean, what about windows and linux? Can you give us styles for that? For that matter, how would you feel about making a patch directly? I can point you at the right files.
Assignee: nobody → smartell
Blocks: 585689
Reporter | ||
Updated•14 years ago
|
Reporter | ||
Updated•14 years ago
|
Priority: -- → P3
Updated•14 years ago
|
Priority: P3 → P4
Comment 3•14 years ago
|
||
I'm pretty pressed with engagement work leading up to Fx4, so if someone else could adapt the latest styles on my link, that'd be great.
Windows is here:
http://mozilla.seanmartell.com/tabcandy/index-win2.html
note in the OSX version that I actually use -moz-mac-focusring for the blue highlights to maintain OS consistency. It doesn't appear to be that way in the latest nightly.
Updated•14 years ago
|
Assignee: smartell → nobody
Reporter | ||
Comment 4•14 years ago
|
||
So... I started working on this but there are a few issues:
1. The pinstripe adjustment will involve a change to chrome://browser/skin/tabview/tabview.png, due to the updated background color
2. The mockup we have doesn't have any mockup for what it should look like (or what styling to use) when one button on the #actions bar is depressed, while another is not.
3. The styling of the search field is actually quite different now from what's in the mockup, so simply applying the focusring CSS looks really bad.
(1) is pretty easily fixed. Sean, do you mind if, for fx4, we just have no depressed CSS for the action buttons, and don't make any changes for the search box?
Reporter | ||
Comment 5•14 years ago
|
||
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•14 years ago
|
||
[bugspam: betaN -> future]
Reporter | ||
Updated•14 years ago
|
Assignee: mitcho → nobody
Comment 10•13 years ago
|
||
bugspam
(Fx7 was branched, removing open bugs from Fx7 meta bug, we won't create new meta bugs for upcoming Fx versions)
No longer blocks: 660175
Whiteboard: [visual][polish][good first bug] → [visual][polish]
Comment 11•9 years ago
|
||
Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.
If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.
See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.
We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•