Closed Bug 626739 Opened 14 years ago Closed 8 years ago

"Run Filters on Folder" doesn't activate any action - Filters do NOT get run

Categories

(MailNews Core :: Filters, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: mtkatrev, Unassigned)

Details

(Whiteboard: [filterfails][dupeme?])

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 ( .NET CLR 3.5.30729) Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 ( .NET CLR 3.5.30729) It has happened to me most of the time; occasionally, I can get it to run. When I click on Tools -> Run Filters on Folder, nothing happens. I also get the same result when I open Tools -> Message Filters and highlight a single filter and click "Run Now". I was able to run it yesterday (I believe once) and then could not run again. I tried closing SeaMonkey; I tried rebooting my computer. I cannot get the filters to run again at this time. Reproducible: Sometimes Steps to Reproduce: 1. Click on Inbox to highlight 2. Click Tools -> Run Filters on Folder 3. Actual Results: Nothing runs; no progress bar, mail still appears in Inbox that should've been moved. (in the past a progress bar appeared in the status bar to indicate progress) Expected Results: Progress bar should appear, mail should be moved to appropriate location as indicated in the Message Filters I have also experienced the issue with check marked Message Filters changing to dots indicating that they are no longer enabled when messages arrive that meet the criteria for the filter. Running XP MCE sp 3 SeaMonkey version 2.0.11 Built from http://hg.mozilla.org/releases/mozilla-1.9.1/rev/54745ba055f0
Component: General → MailNews: General
QA Contact: general → mail
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b11pre) Gecko/20110202 Firefox/4.0b11pre SeaMonkey/2.1b2pre I an currently experiencing this same exact issue with SM2b2pre.
should be a dupe of a "manual" filter run bug
Component: MailNews: General → Filters
Product: SeaMonkey → MailNews Core
QA Contact: mail → filters
Whiteboard: dupeme
I see this happen, but only some of the time. It seems to depend on the account in which the filters are defined. (That is, if your mail account in Thunderbird is "mail.myisp.com" but it moves the messages to Local Folders/inbox, then a filter set up under "Local Folders" will run on messages already in your inbox, but a filter set up under "mail.myisp.com" will not.)
(In reply to comment #3) > (That is, if your mail account in > Thunderbird is "mail.myisp.com" but it moves the messages to Local > Folders/inbox, then a filter set up under "Local Folders" will run on > messages already in your inbox, but a filter set up under "mail.myisp.com" > will not.) That is really by design. Once the messages have moved to Local Folders, then a manual filter does not know from whence it came, so the original account filter would not apply. On incoming, if a POP3 account is deferred to the local folder, then filters on both the POP3 account and the local folder account will apply. But because manual filters would need to run on Local Folders, the filter should really be created on Local Folders in that case (and a few revisions back we changed the default create filter location to Local Folders in that case.) I'm not claiming this design is great, in fact it is terribly confusing and hard to use. But that is the design.
(In reply to comment #4) > (In reply to comment #3) > > (That is, if your mail account in > > Thunderbird is "mail.myisp.com" but it moves the messages to Local > > Folders/inbox, then a filter set up under "Local Folders" will run on > > messages already in your inbox, but a filter set up under "mail.myisp.com" > > will not.) > > That is really by design. Once the messages have moved to Local Folders, > then a manual filter does not know from whence it came, so the original > account filter would not apply. Why can't it use the x-account-key, if present?
(In reply to comment #5) > Why can't it use the x-account-key, if present? I suppose it could. How far would you take that? Just for deferred-to-local POP3 accounts? (You could also make the case I suppose that, for example, IMAP filters that move messages to another IMAP account should also apply the filters from the original account on manual filtering). You would have to add to any existing filters on the account an additional search term for x-account-key, then run them.
(In reply to comment #6) > (In reply to comment #5) > > Why can't it use the x-account-key, if present? > > I suppose it could. How far would you take that? Just for deferred-to-local > POP3 accounts? Either that, or for pop3 accounts in general, since I think we always write the x-mozilla-account-key header whenever we download for pop3, even when not deferring to the local folders account. So you could simply just apply the filters to message that have the right account key. (You could also make the case I suppose that, for example, > IMAP filters that move messages to another IMAP account should also apply > the filters from the original account on manual filtering). You would have > to add to any existing filters on the account an additional search term for > x-account-key, then run them. We don't have an account-key for imap messages. The imap case is weak, compared to the pop3/local mail folder case. In the later case, we actively encouraged users to use the local mail folder inbox for some time.
Whiteboard: dupeme → [filterfails][dupeme?]
(In reply to Trevor from comment #0) > It has happened to me most of the time; occasionally, I can get it to run. > When I click on Tools -> Run Filters on Folder, nothing happens. Does your "nothing happens" mean "you can not see progress bar"? What is written in "Filter Log"? How about filterlog.html file content after manual filter execution? Is there any difference between "before filter execution" and "after filter execution"? (file in Mail directory for the account) How about filterlog.html file content after termination of Tb? Is there any difference between "before termination of Tb" and "after termination of Tb"? Do you use action of "Delete" or "Stop Filter Execution"? If yes, same problem as bug 695671?
It didn't happen to me today so I will keep an eye on it to happen again. I have applied a lot of upgrades since this was an issue though I believe I did experience it a few weeks ago. Does your "nothing happens" mean "you can not see progress bar"? - See initial report (under "Actual Results"). What is written in "Filter Log"? - Thanks for the tip about the "Filter Log"! I will watch this file if/when it happens again. How about filterlog.html file content after manual filter execution? - Again, I didn't know about this file. Is there any difference between "before filter execution" and "after filter execution"? (file in Mail directory for the account) - See initial report (under "Actual Results"). How about filterlog.html file content after termination of Tb? Is there any difference between "before termination of Tb" and "after termination of Tb"? - No Do you use action of "Delete" or "Stop Filter Execution"? - No
I have same problem as Trevor. The filters do not run automatically. Upon clicking Run Filters on Folder, only one filter runs from the list but the rest do not. If I click on Run Filters on Folder again, the next filter in the list runs but the rest do not. And so on and so on. If I go to Message Filters, place the cursor on a filter, and Click on Run Now, it runs.
(In reply to Trevor from comment #0) > Steps to Reproduce: > 1. Click on Inbox to highlight > 2. Click Tools -> Run Filters on Folder > Actual Results: > Nothing runs; no progress bar, mail still appears in Inbox that should've > been moved. > (in the past a progress bar appeared in the status bar to indicate progress) At which account's Inbox of folder pane? (a) Inbox of POP3 account (b) Inbox of IMAP account (c) Inbox of "Local Folders" If (c), do you enable "Global Inbox" for a POP3 account? If (c) and Global Inbox is used, filter used by "Run Filters on Folder" is filter for "Local Folders" instead of filter for deffering POP3 account(account is hidden at folder pane). Please surely rule out "filter of deffering POP3 account(account is hidden at folder pane) doesn't run by Run Filters on folder" case. What "Folder View"? All? Unified? or other view? There are known issues in "Run Filters on folder". (a) bug 393668 : when mail is already placed in move target folder of "Move To" (b) bug 552936 : when Stop Filter Execution is used as action (c) bug 695671 : when Delete is used as action In any case, "filter upon download" and "Run Filters on Selected Messages" works well as expected. As you say Delete/Stop Filter Execution is not used, (b)/(c) is irelevant to your problem, but (a) can occur on any mail folder of any account, if "Run Filters on folder" is executed on a folder which is specified as move target folder of "Move To". Please surely rule out this already known issue from your problem.
I will answer for me. It is Inbox of POP3 account. It is not IMAP or local folders, and global inbox is not enabled. Folder view is All. The other listed bugs may be relevant, because (1) some of my filters use "move to" commands; (2) I do not have the stop filter execution used as an action; and (3) some of my filters use "delete" commands. However, your description of the "move to" bug does not seem to be correct. It appears that that bug halts execution of all filters after doing a "move to," regardless of the contents of the folder the message is moved to. The summary f that bug is: "Summary: When a rule of "move to" fired on a mail in the move target folder("Run Filters On" is requested), rules defined under the fired rule will not be applied to other mails("Run Filters on Folder" only issue. "Run ... on Selected Messages" works well) → When a rule of "move to" fired on a mail in the move target folder("Run Filters On" is requested), rules defined under the fired rule will not be applied to other mails("Run Filters on Folder"/"Run Now" issue. "Run ... on Selected Messages" works well)"
Also, I am not trying to run filters on any "move target folder."
(In reply to Dan Meek from comment #12) > (3) some of my filters use "delete" commands. Did you actually read thru and understand bug 695671? Read also bug 393668 well, please. (In reply to Dan Meek from comment #10) > Upon clicking Run Filters on Folder, only one filter runs from the list but the > rest do not. > If I click on Run Filters on Folder again, the next filter in the list runs but the rest do not. And so on and so on. Phenomenon of bug 695671 : "If cond-1, Delete" fires on mail-1-1, mail-1-2, ..., mail-1-N, "If cond-2, Move to folderX" for other mail-2-N is not executed, if "Run Filters on folder". In this case, second run is usually successful, because mail-1-1, mail-1-2, ..., mail-1-N is deleted by first run and "If cond-1, Delete" never fires in second run. Phenomenon of bug 393668 : If "Run Message Filters on Folder-1" and if "If cond-1, Move to Folder-1" fires on mail-1-N in Folder-1, "If cond-2, Move to Folder-2" for other mail-2-N is not excuted, if "Run Filters on folder". In this case, second run always fails to move mail-2-N, because "If cond-1, Move to Folder-1" fires on mail-1-N in Folder-1 again.
(In reply to Dan Meek from comment #12) (1) some of my filters use "move to" > commands; >(2) I do not have the stop filter execution used as an action; and > (3) some of my filters use "delete" commands. Both "Move to" and "Delete" actions implicitly contain "Stop filter execution" (as if it was specified as the last action).
Interesting, but knowing that does not solve the problem.
As for understanding the other bugs, I read those pages but do not claim to be a programmer with complete understanding. As for "second run is usually successful," that is not the case for me. Each run stops after executing approximately one filter (of a few dozen). If I mark all the email in the inbox and choose Run Filters on Selected Messages, then that does work.
(In reply to Dan Meek from comment #16) > Interesting, but knowing that does not solve the problem. Only that if "Stop filter execution" is involved (implicit or explicit) then bug 695671 is better for you. You say the first filter gets run. The original report says NO filters get run (or randomly).
When I first encountered this problem, I also thought that no filters were being run. It took some testing to find that they were running, although only one per click on Run Filters on Folder. That may be the case for the person who started this bug as well. When I click on Run Filters on Folder, it appears that nothing happens. There is no progress bar. In the filter log, it shows that indeed only one filter ran. If I clear the filter log and click on Run Filters on Folder again, it again appears to do nothing, but the filter log shows that the same single filter ran again. It is not my first filter in sequence; it is the 7th one.
(In reply to Dan Meek from comment #16) > Interesting, but knowing that does not solve the problem. A simplest workaround is apparent, "Run Filters on Selected Messages" instead of "Run Filters on folder", because known bugs won't occur if "Run Filters on Selected Messages". What is reason why you still adding complaints even though Tb's bug(actual flaw in code) becomes apparrant? Have you actually read thru and understand aleady known bugs?
I do not seem to have this issue any longer. Because my filters get "unchecked" (un-enabled) when I receive an email that matches that criteria, I was able to check (enable) multiple filters and observe the behavior. No matter what I tried, every click on "Run Filters on Folder" moved all relevant emails to the appropriate location. Since this issue was inconsistent, I will watch for this condition and report if it happens again. I am now on Windows 7 - 64 bit http://hg.mozilla.org/releases/mozilla-release/rev/75b17db9b6e9 Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120312 Firefox/11.0 SeaMonkey/2.8
Trevor, if each of your filters get "unchecked" when you receive an email that matches the criteria of the filter, that is a very significant bug in TB.
Well, WADA, I would like TB to work properly. There is a "Run Filters on Folder" choice, so it should work. As it does not, thousands of TB users will be confused. Some of them may discover on their own the workaround, as I did, but there should be no need for a workaround and no need for TB users to discover it. As for "adding complaints," I was resonding to your questions. Should I look forward to more hostility from you?
Don't worry, no hostility. We just want to find out if there are multiple problems (bugs) or all the filed bugs boil down to the one problem with "stop filter execution".
I am using Seamonkey (2.8). I don't actually know what "stop filter execution" is. It sounds like an option to stop running filters at a certain point in the execution? Is this an option Seamonkey does not have (or am I missing something)? The disabling of filters is one I've reported (bug 714364) and have always had. I am surprised it hasn't received more attention. I wonder how I could be the only one experiencing it. I am a huge fan of all the Mozilla applications that I use (Seamonkey, Lightning, Firefox [though, this one is changing too often nowadays, making it less appealing]). Thanks for your help!
"stop filter execution" is an action that you can choose in the filter editor, it is in the menu where you select "move to/copy to/tag/delete/, all those actions. It says that no further filters should be applied to the message that matched the current filter (even if it would match those too).
Re. comment 26 -- I have always assumed this was true of all filters (that is, once a filter matches the message and moves it to folder X, no further filter actions should be taken on that message). I would not want this behavior changed unless I get an option to keep it the same.
Well, MOVE implies "stop filter execution" so you are unconsciously using it (see comment 15):) But try to make a filter doing just TAG and another one Mark as Read and they should apply both to the same message (if you make the criteria the same). If you didn't want the Mark as Read to be applied to the message Tagged, you would need to add and explicit "stop filter execution" rule into the first filter. Try it out.
Ah, thanks. I never noticed that was there. I've never used it. It sounds like quite a "special case" scenario.
Yeah, maybe it is not used much. And that may explain why nobody noticed it is not working correctly, until it is finally bubbling out from these bug reports :)
I think there is some misunderstanding about this bug. For me, Run Filters on Folders executes only one of my 3 dozen filters. Yes, the one filter may have a "delete the message" in it, but that should not stop all the other filters from running. I would think that "delete message" is a rather common command to put in filters.
how does summary need to be changed before confirming bug?
I am not sure anybody knows what is the actual problem here.
Please close this ticket as it is no longer an issue.
It is an issue, because it still happens. Clicking on Run Filters on Folder runs only one filter.
(In reply to Trevor from comment #34) > Please close this ticket as it is no longer an issue. meaning ... it works correctly for you using newer version, using the original steps / original conditions?
(In reply to get from comment #35) > It is an issue, because it still happens. Clicking on Run Filters on Folder > runs only one filter. This is not what the original report says and your problem should be bug 695671.
Is anyone working to fix that bbug?
I believe this may be a user error based on my other ticket that I have reported. Here's what I believe I experienced... When I opened my email (SeaMonkey) many of the emails I received that I had "Message Filters" set up for would show in my inbox. I would click on "Run Filters on Folder" and nothing would happen. I later realized that nothing happened because of the other reported issue (when I open email in SeaMonkey, the "Run Filters" items for which I receive emails become disabled [unchecked]). Not realizing they were unchecked, I believed the "Run Filters on Folder" was not working properly. If I check the Filters that had become unchecked and "Run Filters on Folder" those emails were properly moved to the destination folders. There could be more information provided when the "Run Filters on Folder" gets run that would help the user understand what happened. For example (though, I am not a designer) : When the user clicks on "Run Filters on Folder" a popup window could be displayed that shows a progress bar and at termination displays the number of emails that were moved. Click on "ok" to acknowledge with the option to "Don't show this message in the future". There would need to be an option in "Mail & Newsgroups Account Settings" under "Copies & Folders" (or somewhere?) that allows you to check or uncheck the "Notify me how many emails were moved to folders using 'Run Filters on Folder'" (or something like that). Sorry for the confusion. I hope that helps.
For me, all of my filters are still checked and yet only the first one runs upon clicking on Run Filters on Folder.
(In reply to get from comment #40) What do your filters *do* when triggered? It came up recently in another bug that if one of your filters causes a message to be moved to another folder, no further filters (of the folder you just moved it out of) will be run for that message. This is by design.
No, it is not by design. No further filters are applied to the message being moved (or deleted or "stop filter execution"-action). However filters should be applied normally on the other messages in the original folder. But there is bug 695671 about this not working correctly and stopping any further filter execution. So if ONE of your filters having one of these actions does something and the rest do not, that is your bug. If NO filters ever run, it is this bug (which Trevor reported originally).
:aceman, you are good to have on the team. Most importantly, the "one of the filters is run and nothing else is run is NOT the bug I have reported and is, in fact, reported as bug 695671 as :aceman stated. So, please do not discuss that issue here and cause confusion. Take that discussion to the appropriate bug. Thanks. I think the issue here could be considered an enhancement rather than a bug.
Can we close this based on comment 34 ?
Just an observation, in my case one filter was not run 'On Folder' or 'On Message'. The filter created was based on a From address that included 3 suffixes in the address. For example: Support@mailcenter.yada.com Correction: To correct the problem I used the "ends with" condition and "yada.com" as the qualifier. This was the only way I could get the filters to run. Problem Focus: I suspect the filter utility truncates everything after the field following the first period. This suggests it is only registering a "Support@mailcenter.yada" qualifier in my situation. I hope this is helpful. Cheers, A>AM
(In reply to :aceman from comment #44) > Can we close this based on comment 34 ? yes
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.