This is a follow up bug from bug 607224. The following menu commands should be hidden unless the user invokes the menu using the keyboard: File > Open Location File > Close Window File > Close Tab Edit > Delete (available through a context menu on a text field) Edit > Find Again View > Stop View > Reload History > Back History > Forward History > Home Tools > Web Search Initially this change is for Windows/Linux, since those were the platforms covered by the patch in bug 607224.

The UX team is very eager to get this bug landed over the next few days in order to make Beta 11. If anyone can get a patch for this bug posted soon, we will push hard for reviews and approval (even though this isn't blocking). You can view all of the related bugs to clean up the traditional menu bar here: http://areweprettyyet.com/4/traditionalMenu/

the current patch in Bug 588011 has some code to make this pretty much trivial (matter of adding a class/attribute to the menuitem)

Thanks Marco, this makes it so trivial it's almost boring ;-) I'll try to post a first patch in the evening.

(In reply to comment #3) > Thanks Marco, this makes it so trivial it's almost boring ;-) > I'll try to post a first patch in the evening. thanks, notice the name of the class is not yet finalized since I'm waiting for the final signup from dao.

Per the mockup (comment 1), this makes these menu items show-only-for-keyboard: File > Open Location File > Close Window File > Close Tab Edit > Find Again View > Stop View > Reload History > Back History > Forward History > Home Tools > Web Search From the list in comment 0, this leaves Edit > Delete untouched, since that's not in the mockup. Built on top of patch v1.4 in bug 588011. Reduced diff context to prevent bitrotting. Passes browser-chrome tests locally, but doesn't include a test.

Also included the menuseparators after View->Reload and Tools->Web Search. Those are easily overlooked in Ubuntu's Ambiance theme :-(

Correct patch. Need to sleep.

Unbitrotted (patch context has changed).

Bug 607224, which made this possible, was marked as blocking2.0:betaN, so requesting blocking here as well.

Not blocking, but will approve the patch.

Comment on attachment 508868 [details] [diff] [review] unbitrotted a=beltzner

Verified on Mozilla/5.0 (Windows NT 6.1; rv:2.0b11) Gecko/20100101 Firefox/4.0b11

http://hg.mozilla.org/mozilla-central/rev/60c78add19a8 Adding relnote and user-doc-needed; the same was done for menu Bookmarks -> "Bookmarks All Tabs" in bug 588011.

Note that this doesn't work Mac, see bug 607224 comment 38, i.e. Mac always shows all menu items.

Verified fixed with Mozilla/5.0 (Windows NT 6.1; rv:2.0b12pre) Gecko/20110220 Firefox/4.0b12pre and Mozilla/5.0 (X11; Linux x86_64; rv:2.0b12pre) Gecko/20110220 Firefox/4.0b12pre Litmus tests which have been updated: https://litmus.mozilla.org/show_test.cgi?id=10036 (File menu) https://litmus.mozilla.org/show_test.cgi?id=10037 (Edit menu) https://litmus.mozilla.org/show_test.cgi?id=10035 (View menu) https://litmus.mozilla.org/show_test.cgi?id=10034 (History menu) https://litmus.mozilla.org/show_test.cgi?id=10032 (Tools menu)

May I ask why this was even considered a bug? I skimmed through the comments in bug 607224 and agree with the last comment by arromdee. How is it a bad thing to maintain consistency when displaying commands? What difference does it make if I open it with the mouse or the keyboard? In my (admittedly likely narrow) case, I sometimes hit Alt just to bring up the menu and then click to what I'm really looking for, so if I hit Alt to see the menu but then click on the Bookmarks menu, I don't see the "Bookmark all tabs" command. I recently upgraded from Firefox 3.6 to 8 and was confused by the seeming absence of that command. Had to Google it to find out I can access it through a right click, and then learned it was actually removed on purpose. This does not make sense to me. I can understand wanting to streamline the interface by removing unnecessary options from the user's constant view (the main browser window, with the tabs and the actual page being read), but opening a menu, regardless of whether by mouse or keyboard, should make it obvious that I *want* more stuff to suddenly appear on my screen. Why hide some of it? Pedro