Open
Bug 627236
Opened 14 years ago
Updated 1 year ago
can't reopen/undismiss doorhanger with a null anchor ID
Categories
(Toolkit :: PopupNotifications and Notification Bars, defect)
Toolkit
PopupNotifications and Notification Bars
Tracking
()
NEW
People
(Reporter: Gavin, Unassigned)
References
Details
(Whiteboard: [doorhanger])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Gavin
:
feedback-
|
Details | Diff | Splinter Review |
Support for this was introduced in bug 617553. BEcause of the way we try to find notifications to display on iconbox clicks, we end up just hiding the anchor icon when you click on it, rather than redisplaying the notification.
|
Reporter | |
Comment 1•14 years ago
|
||
This fixes it, not sure if I like having to use getElementById().
|
||
Comment 3•13 years ago
|
||
This should definitively be fixed for Firefox 6!
A much more easier way would be to explicitly use "#default-notification-icon" as anchor if anchorID is null, because this icon is displayed in such case.
|
|
||
Comment 4•13 years ago
|
||
uses default-notification-icon if anchorID is null AND makes the default-notification-icon "usable" (show it if used)
|
|
||
Comment 5•13 years ago
|
||
more thorough version of my previous patch ... always use default-notification-icon as fallback
Attachment #544855 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 6•13 years ago
|
||
Comment on attachment 544861 [details] [diff] [review]
use default-notification-icon as fallback
Thanks for looking into this, but unfortunately this isn't a suitable solution, because "default-notification-icon" only exists in Firefox - this module lives in toolkit and is used by other apps.
My previous patch in this bug is what we want, I think.
Attachment #544861 -
Flags: feedback-
|
||
Comment 7•11 years ago
|
||
Bulk move to Toolkit::Notifications and Alerts
Filter on notifications-and-alerts-component.
Component: General → Notifications and Alerts
|
||
Updated•2 years ago
|
Severity: normal → S3
|
||
Updated•1 year ago
|
Component: Notifications and Alerts → PopupNotifications and Notification Bars
You need to log in
before you can comment on or make changes to this bug.
Description
•