Closed Bug 627328 Opened 14 years ago Closed 14 years ago

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' (required for Personas Plus compatibility)

Categories

(Core :: XUL, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b12
Tracking Status
blocking2.0 --- final+

People

(Reporter: cbook, Assigned: mounir)

References

Details

(Keywords: assertion)

Attachments

(2 files, 1 obsolete file)

###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /work/mozilla/builds/2.0.0/mozilla/content/events/src/nsEventDispatcher.cpp, line 514 Steps to reproduce: -> Use the latest Personas Demo on a Mac Debug Build - see Bug 598144 -> Change a Persona -->> Assertion ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error'
The stack for the assertion would be useful.
Attached file stack (deleted) —
(In reply to comment #1) > The stack for the assertion would be useful. yeah attached, sorry had problems to run fix_mac_stack before.
sWebShellWindow::HandleEvent(nsGUIEvent*) (nsWebShellWindow.cpp:360, in XUL) nsCocoaWindow::DispatchEvent(nsGUIEvent*, nsEventStatus&) (in XUL) (nsCocoaWindow.mm:1420) sCocoaWindow::ReportSizeEvent() (nsCocoaWindow.mm:1482, in XUL) --[ToolbarWindow setDrawsContentsIntoWindowFrame:] (in XUL) (nsCocoaWindow.mm:2355) sCocoaWindow::SetDrawsInTitlebar(int) (nsCocoaWindow.mm:1690, in XUL) sXULElement::SetDrawsInTitlebar(int) (nsXULElement.cpp:2424, in XUL) nsXULElement::UnsetAttr(int, nsIAtom*, int) (in XUL) (nsXULElement.cpp:1441) nsGenericElement::RemoveAttribute(nsAString_internal const&) (in XUL) (nsGenericElement.cpp:2407) Somewhere in here it seems like badness is beginning. Can we maybe call nsXULElement::SetDrawsInTitlebar asynchronously or off of a scriptrunner? Or rather, make nsXULElement::SetDrawsInTitlebar call into the widget code off of a scriptrunner/asynchronously?
Just want to verify: is this blocking progress on bug 598144? I'd really like to be able to get the add-on updated since it is one of our most popular add-ons. Is there anything I can do to help get movement on this bug if so?
cc'ing Neil. Neil, do you know if we can call nsXULElement::SetDrawsInTitlebar asynchronously? Or from a scriptrunner?
I do not know, but it doesn't look like it would be a problem.
blocking2.0: --- → ?
Component: General → DOM: Events
QA Contact: general → events
Summary: ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' → ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' (required for Personas Plus compatibility)
Component: DOM: Events → XUL
QA Contact: events → xptoolkit.widgets
Let's do it!
blocking2.0: ? → final+
Assignee: nobody → mounir.lamouri
Attached patch Patch v1 (obsolete) (deleted) — Splinter Review
Attachment #509410 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Comment on attachment 509410 [details] [diff] [review] Patch v1 r=me
Attachment #509410 - Flags: review?(bzbarsky) → review+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Backed out: http://hg.mozilla.org/mozilla-central/rev/64cb344a0145 First patch I don't send to try since a *very* long time and, of course, it creates orange :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch with test fixes (deleted) — Splinter Review
Attachment #509410 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Depends on: 632396
No longer depends on: 632396
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: