Closed
Bug 627328
Opened 14 years ago
Closed 14 years ago
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' (required for Personas Plus compatibility)
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b12
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: cbook, Assigned: mounir)
References
Details
(Keywords: assertion)
Attachments
(2 files, 1 obsolete file)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file /work/mozilla/builds/2.0.0/mozilla/content/events/src/nsEventDispatcher.cpp, line 514
Steps to reproduce:
-> Use the latest Personas Demo on a Mac Debug Build - see Bug 598144
-> Change a Persona
-->> Assertion ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error'
Comment 1•14 years ago
|
||
The stack for the assertion would be useful.
Reporter | ||
Comment 2•14 years ago
|
||
Reporter | ||
Comment 3•14 years ago
|
||
(In reply to comment #1)
> The stack for the assertion would be useful.
yeah attached, sorry had problems to run fix_mac_stack before.
sWebShellWindow::HandleEvent(nsGUIEvent*) (nsWebShellWindow.cpp:360, in XUL)
nsCocoaWindow::DispatchEvent(nsGUIEvent*, nsEventStatus&) (in XUL) (nsCocoaWindow.mm:1420)
sCocoaWindow::ReportSizeEvent() (nsCocoaWindow.mm:1482, in XUL)
--[ToolbarWindow setDrawsContentsIntoWindowFrame:] (in XUL) (nsCocoaWindow.mm:2355)
sCocoaWindow::SetDrawsInTitlebar(int) (nsCocoaWindow.mm:1690, in XUL)
sXULElement::SetDrawsInTitlebar(int) (nsXULElement.cpp:2424, in XUL)
nsXULElement::UnsetAttr(int, nsIAtom*, int) (in XUL) (nsXULElement.cpp:1441)
nsGenericElement::RemoveAttribute(nsAString_internal const&) (in XUL) (nsGenericElement.cpp:2407)
Somewhere in here it seems like badness is beginning. Can we maybe call nsXULElement::SetDrawsInTitlebar asynchronously or off of a scriptrunner?
Or rather, make nsXULElement::SetDrawsInTitlebar call into the widget code off of a scriptrunner/asynchronously?
Comment 5•14 years ago
|
||
Just want to verify: is this blocking progress on bug 598144? I'd really like to be able to get the add-on updated since it is one of our most popular add-ons.
Is there anything I can do to help get movement on this bug if so?
cc'ing Neil.
Neil, do you know if we can call nsXULElement::SetDrawsInTitlebar asynchronously? Or from a scriptrunner?
Comment 7•14 years ago
|
||
I do not know, but it doesn't look like it would be a problem.
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
Component: General → DOM: Events
QA Contact: general → events
Summary: ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' → ###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error' (required for Personas Plus compatibility)
Updated•14 years ago
|
Component: DOM: Events → XUL
QA Contact: events → xptoolkit.widgets
Let's do it!
blocking2.0: ? → final+
Assignee: nobody → mounir.lamouri
Assignee | ||
Comment 9•14 years ago
|
||
Attachment #509410 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Comment 10•14 years ago
|
||
Comment on attachment 509410 [details] [diff] [review]
Patch v1
r=me
Attachment #509410 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 11•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b12
Assignee | ||
Comment 12•14 years ago
|
||
Backed out:
http://hg.mozilla.org/mozilla-central/rev/64cb344a0145
First patch I don't send to try since a *very* long time and, of course, it creates orange :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•14 years ago
|
||
Attachment #509410 -
Attachment is obsolete: true
Assignee | ||
Comment 14•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Depends on: 632994
You need to log in
before you can comment on or make changes to this bug.
Description
•