Closed Bug 627824 Opened 14 years ago Closed 14 years ago

DirectWrite causes some text in menus to be cut off

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla2.0b11
Tracking Status
blocking2.0 --- final+

People

(Reporter: rain1, Unassigned)

References

()

Details

(Whiteboard: [hardblocker][fx4-fixed-bugday])

Attachments

(2 files)

I'm pretty sure this is a recent regression. The text in the URL should be "Restart with Addons Disabled", I'm guessing.
This doesn't happen without DWrite enabled. It also happens in Thunderbird, where the "Troubleshooting Information" in the Help menu is cut off to "Troubleshooting Informati...".
blocking2.0: --- → ?
Text metrics are different with DirectWrite - the frontend just needs to be adjusted for that.
Component: Graphics → Menus
Product: Core → Firefox
QA Contact: thebes → menus
Isn't the menu width automatically computed based on the text metrics?
I don't know, but Neil might!
(In reply to comment #3) > Isn't the menu width automatically computed based on the text metrics? Yes, indirectly, but to a maximum width of 42em as specified in menu.css
blocking2.0: ? → final+
Whiteboard: [hardblocker]
Axel: I bet this will have l10n impact. Dao: can you look at this? I'm hoping there's an easy fix, as it's late in the game. Joe: can you make a mental note to give the front end team a heads up when doing things that will affect CSS layout ... or rendering of the UI in general?
This regressed between 2011-01-17 and 2011-01-18: the regression range is <https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66addc5c30ca&tochange=eb105fe0e41c>.
--> Core::Layout as per JOEDREW!
Component: Menus → Layout
Product: Firefox → Core
QA Contact: menus → layout
Attached image missing space after text (deleted) —
In my example missing space after text "Cauta in toate suplimentele" in search box in addons manager.
I recall that margaret fixed a menu cut-off bug, too, but I can't find it just now.
Backing out part 1 of bug 562138 fixes this.
Blocks: 562138
(In reply to comment #12) > I recall that margaret fixed a menu cut-off bug, too, but I can't find it just > now. Bug 585253, but that should only affect bookmark/history menuitems.
Blocks: 628968
Fixed by backout of bug 562138.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
No longer blocks: 628968
Attached image final letters missing (deleted) —
Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110129 Firefox/4.0b11pre ID:20110129030338 Translate is correct.
This bug is NOT resolved. In two situation final letters is cut in my Minefield (romanian localized). If sentences are greater more final letter missing (cut off). Please see in attachments. Mozilla/5.0 (Windows NT 6.1; rv:2.0b11pre) Gecko/20110129 Firefox/4.0b11pre ID:20110129030338
That's not this bug, this bug is about menus. Please file a new bug.
Hi Raul. The problem you are seeing is not this bug. http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#62 states that the string must fit in a 32 byte buffer, the ro string is currently 33 byte.
(In reply to comment #24) > Hi Raul. The problem you are seeing is not this bug. > http://mxr.mozilla.org/l10n-central/source/ro/security/manager/chrome/pipnss/pipnss.properties#62 > states that the string must fit in a 32 byte buffer, the ro string is currently > 33 byte. And what is resolved procedure?
see comment 23, your bug is different and this bug is resolved.
Verified fixed inMozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre
Status: RESOLVED → VERIFIED
Whiteboard: [hardblocker] → [hardblocker][fx4-fixed-bugday]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: