Open
Bug 628315
Opened 14 years ago
Updated 2 years ago
Bookmark sync: use SQL for all read operations
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
NEW
People
(Reporter: philikon, Unassigned)
Details
(Whiteboard: [Snappy:P2][sync:bookmarks])
We can bypass a lot of synchronous read operations in nsINavBookmarkService by directly using SQL. These will be async where available and often even simpler to use than Places' query API. (Maybe not on 3.5/3.6 where we need to make JOINs to get GUIDs.)
Comment 1•14 years ago
|
||
\o/
Comment 2•14 years ago
|
||
This is likely true, but makes me sad. Monkeypatching ftl!
Reporter | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> This is likely true, but makes me sad. Monkeypatching ftl!
No monkey patching needed... Just stop using the APIs in nsINavBookmarkService and run queries against its DBConnection instead. We already do that in *some* parts of the bookmark engine (cf bug 615410, bug 623418), just not in all.
Going fwd we could even use a separate read-only db connection to avoid lock contention with simultaneous write operations.
Updated•13 years ago
|
Whiteboard: [Snappy]
Comment 4•13 years ago
|
||
Marco, assigning it to you to reprioritize this for snappy purposes or wontfix.
Assignee: nobody → mak77
Whiteboard: [Snappy] → [Snappy:P2]
Comment 5•13 years ago
|
||
Marco says P2 is correct.
< mak> taras: I discussed that with rnewman already, I think Sync team may have resources in January
rnewman can reassign this in his team
Assignee: mak77 → rnewman
Comment 6•12 years ago
|
||
See also Bug 519514, which might be a better approach.
Assignee: rnewman → nobody
Whiteboard: [Snappy:P2] → [Snappy:P2][sync:bookmarks]
Assignee | ||
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•