Closed Bug 628627 Opened 14 years ago Closed 14 years ago

Should display a message about --disable-elf-hack when elfhack fails

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b11

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(2 files, 1 obsolete file)

part 1 - Raise hard errors in some more cases in elfhack
(deleted), patch
taras.mozilla
: review+
sdwilsh
: approval2.0+
Details | Diff | Splinter Review
part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures
(deleted), patch
glandium
: review+
sdwilsh
: approval2.0+
Details | Diff | Splinter Review
Some things that are only warning at the moment should also trigger an actual error (like unsupported relocations)
Currently, some errors that are very likely to lead to broken binaries are just displayed as warnings, this makes them hard errors.
Attachment #507062 - Flags: review?(tglek)
(In reply to comment #1) > Created attachment 507062 [details] [diff] [review] > part 1 - Raise hard errors in some more cases in elfhack > > Currently, some errors that are very likely to lead to broken binaries are just > displayed as warnings, this makes them hard errors. Also, assertions are only taken into account in debug builds, here we do that in all builds
This adds a message before running the elfhack test and running elfhack during packaging to give some awareness about what do do in case of failure
Attachment #507063 - Flags: review?(tglek)
Attachment #507062 - Flags: review?(tglek) → review+
Comment on attachment 507063 [details] [diff] [review] part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures I don't think i'm the right person to review this. I doubt this kind of message spam is even needed.
Attachment #507063 - Flags: review?(tglek) → review?(mwu)
Comment on attachment 507063 [details] [diff] [review] part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures !summon build peer
Attachment #507063 - Flags: review?(mwu) → review?(khuey)
Comment on attachment 507063 [details] [diff] [review] part 2 - Add messages inviting to file bugs and use --disable-elf-hack in case of elfhack failures Summoned, I take the place that has been prepared for me. r=me.
Attachment #507063 - Flags: review?(khuey) → review+
FTR, I agree in general about message spam, but we've had a lot of bug reports on this tool, would be nice to keep the message until we've flushed them out.
Taras suggested to remove ac_add_option from the message, what do you think?
Let's go with that, then.
Attachment #507063 - Attachment is obsolete: true
Attachment #507179 - Flags: review+
Attachment #507179 - Flags: approval2.0?
Attachment #507062 - Flags: approval2.0?
Attachment #507062 - Flags: approval2.0? → approval2.0+
Attachment #507179 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/be7d5e061ba6 http://hg.mozilla.org/mozilla-central/rev/78c74aa85e18
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: